Thread: is the program related to the question?

Write a program that computes a running sum of inputs from the user terminating when the user gives an input value of 0.

Code:

#include<iostream>
using namespace std;
int main()
{
int x,y,z;
do
{
cout<<"enter the 1st number:\n";
cin>>x;
cout<<"enter the 2nd number:\n";
cin>>y;
z=x+y;
cout<<"the total is:"<<z<<'\n';
}
while(!(x==0 || y==0));
cout<<"process terminated!";
}

i thought i wont be able to get the program to work if i used a for loop as i have to check if both x and y are 0. so i used a do while loop. thanks

Originally Posted by vart

No, running sum mean you need to continue add numbers til 0 is entered
Output should be something like this

Code:

Enter Number: 10
Running sum: 10, enter next number: 5
Running sum: 15, enter next number: 1
Running sum: 16, enter next number: 3
Running sum: 18, enter next number: 0

Final sum 18, thank you for using our product.

thanks .let me try it

Originally Posted by Elysia

Please indent your code properly and use proper variable names. x, y, z does not tell us much what they're used for.

is this good?..i replaced the x,y and z.

Originally Posted by kmdv

It is a bit better, but:
1. Does your program close when the user enters 0 as the first number? Why it does/does not?
2. Try to remove duplication of code. E.g., in your current solution there are at least 4 lines that are needlessly repeated.
3. Indent as already has been suggested. This will help you to better understand workflow of the code.

Code:

#include<iostream>
using namespace std;
int main()
{
int num1,next_numbers,total;
cout<<"enter the number:\n";
cin>>num1;
cout<<"\nenter next number:\n";
cin>>next_numbers;
if(!(num1==0||next_numbers==0)) //checks if the entered values are not zero
{
total=num1+next_numbers;
cout<<"sum is at:\n"<<total;
for(next_numbers;next_numbers!=0;) //asks the user continuous input until he enters zero
{
cout<<"\nenter next number:\n";
cin>>next_numbers;
total=total+next_numbers;
cout<<"sum is at:\n"<<total;
}
}
}

1.now it closes if the first input is o .
2.i couldn't find the extra lines looks like every line is necessary.

@Elysia is it better?

Originally Posted by Elysia

No, you have not indented properly still. The code is even more unreadable than before.

i added a if statement.how to better indent the code??
i don't get it

Originally Posted by recklezz

i added a if statement.how to better indent the code??
i don't get it

Read: Indent style - Wikipedia, the free encyclopedia
Then start using your tab key.

Originally Posted by Matticus

Read: Indent style - Wikipedia, the free encyclopedia
Then start using your tab key.

Code:

#include<iostream>
using namespace std;
int main()
{
    int num1,next_numbers,total;
    cout<<"enter the number:\n";
    cin>> num1;
    cout<<"\nenter next number:\n";
    cin>> next_numbers;
    if(!(num1==0 || next_numbers==0))         //checks if the entered values are not zero
        {
            total=num1+next_numbers;
            cout<<"sum is at:\n"<<total;
            for(next_numbers;next_numbers!=0;) //asks the user continuous input until he enters zero
                {
                    cout<<"\nenter next number:\n";
                    cin>>next_numbers;
                    total=total+next_numbers;
                    cout<<"sum is at:\n"<<total;
                }
        }       
}

is this ok?
thanks matticus

Originally Posted by recklezz

Code:

#include<iostream>
using namespace std;
int main()
{
    int num1,next_numbers,total;
    cout<<"enter the number:\n";
    cin>> num1;
    cout<<"\nenter next number:\n";
    cin>> next_numbers;
    if(!(num1==0 || next_numbers==0))         //checks if the entered values are not zero
        {
            total=num1+next_numbers;
            cout<<"sum is at:\n"<<total;
            for(next_numbers;next_numbers!=0;) //asks the user continuous input until he enters zero
                {
                    cout<<"\nenter next number:\n";
                    cin>>next_numbers;
                    total=total+next_numbers;
                    cout<<"sum is at:\n"<<total;
                }
        }       
}

is this ok?
thanks matticus

Your formatting looks acceptable, one nit-pick though - you could have:

Code:

total = total + next + next_number

You are free to chose your formatting style - but most formatting styles will look good as long as your remain consistent - for instance 'clang-format' gives me:

Code:

#include <iostream>
using namespace std;
int main() {
  int num1, next_numbers, total;
  cout << "enter the number:\n";
  cin >> num1;
  cout << "\nenter next number:\n";
  cin >> next_numbers;
  if (!(num1 == 0 ||
        next_numbers == 0))  // checks if the entered values are not zero
  {
    total = num1 + next_numbers;
    cout << "sum is at:\n" << total;
    for (next_numbers;
         next_numbers !=
             0;)  // asks the user continuous input until he enters zero
    {
      cout << "\nenter next number:\n";
      cin >> next_numbers;
      total = total + next_numbers;
      cout << "sum is at:\n" << total;
    }
  }
}

That is the coding style used in most google projects.