Thread: Opening a file with stdin?

Greetings all, this board has been a great help so far, and i feel kind of sheepish asking this because I've seen so many post conserning it, but none of the solotions have worked for me.

Anyway I thought was going to be the easiest part of my program: opening a file which the user specifies... i've reviewed the tutorials and past posts and come up with this:

Code:

#include <stdio.h>
#include <stdlib.h>
main()
{
FILE *fp;
char filename[40];
fgets(filename,40,stdin);

if  ( ( fp=fopen(filename, "a+" ) ) != NULL )
{
fprintf(fp, "Testing...\n");
fclose(fp);
}
else printf("Could not open the file: %s", filename);
}

It simpy isnt working for reasons unknown to me (I've also tried the method using BUFSIZ, but still not having any luck); any advice would be appreciated!

Thanks

Your code doesn't compile. This is what it might look like after passing through a beautifier.

Code:

#include <stdio.h>
#include <stdlib.h>
main()
{
   FILE *fp;
   char filename[40];
   fgets(filename,40,stdin);

   if ( (fp=fopen(filename, "a+") != NULL){
        fprintf(fp, "Testing...\n");
      fclose(fp);
      }
      else printf("Could not open the file: %s", filename);
      }

Assuming you just missed the closing paren, read this:
FAQ > How do I... (Level 1) > Get a line of text from the user/keyboard (C)

When you hit enter, it's storing that at the end in your fgets call. You'll want to remove it. To illustrate this, change the "Could not open..." line to have something after the %s, and you'll see that whatever is after it is on a new line.


Quzah.

If you change the

Code:

else printf("Could not open the file: %s", filename);

to

Code:

else printf("Could not open the file: \"%s\"", filename);

you'll see the problem:

Code:

$ ./program
file
Could not open the file: "file
"
$

To remove the newline, see the FAQ mentioned; the strchr() part.