Thread: If command practice

This isnt much of a first post, but im learning and wanted to put together something off the top of my head a "small game"
The problem is that it allways gives me the command like if i pick the number 3, it gives me the words "Your too low, Congrats you win!!"
Am I doing else wrong, why does it display the win command when I didnt win. Also can anyone point me to a way to recycle it so if u dont get the number right it doesnt terminate.

Code:

#include <iostream>

using namespace std;

int main()

{
    int number;
    
    cout<<"Please input a number: \n";
    cin>> number;
    cin.ignore();
    cout<<"You inputted: "<< number << "\n";
    cin.ignore();


    if ( number < 5 ) 
         cout<< " You are too low\n";
         
         else if ( number > 5 ) 
              cout<< " You are too high\n";
              
              
         else ( number == 5 ); 
              cout<< " Congrats you win!!\n";
     
cin.get();
}

the problem is here

Code:

         else ( number == 5 ); 
              cout<< " Congrats you win!!\n";

change this to

Code:

         else
              cout<< " Congrats you win!!\n";

You don't need to specify a condition in an else statement, because else essentially means "do this if none of the previous conditions have been met". also, a semicolon at the end of an if or else statement will signal the end of that statement.

>Also can anyone point me to a way to recycle it so if u dont get the number right it doesnt terminate.

Code:

#include <iostream>

using namespace std;

int main()
{
    int number;

   do {
      cout<<"Please input a number: " << endl;
      cin>> number;
      cin.ignore();
      cout<<"You inputted: "<< number << "\n";
      cin.ignore();

      if ( number < 5 ) 
         cout<< " You are too low\n";
      else if ( number > 5 ) 
         cout<< " You are too high\n";
   } while (number != 5);
              
   cout<< " Congrats you win!!\n";
     
   cin.get();
}

Then you can add another loop to ask the player if they want to play again after they win.

You might want to read this FAQ: FAQ > How do I... (Level 1) > Stop my Windows Console from disappearing everytime I run my program?

thanks a bunch i got it

Edit: What I forgot to ask, is how I can make the number random instead of 5, and if anyone has any recommendations of game programing type tutorial sites or e-books to get started with.

>What I forgot to ask, is how I can make the number random instead of 5
You can use the rand function. Maybe something like:

Code:

#include <cstdlib>
#include <ctime>
#include <iostream>

using namespace std;

int main()
{
    int number;

   //Seed the pseudo random number generator.  Do this only once.
   srand(time(NULL));

   //Generate a number between 1 and 100
   int actual = 1 + (double) rand() * 100 / (RAND_MAX + 1);

   do {
      cout<<"Please input a number: " << endl;
      cin>> number;
      cin.ignore();
      cout<<"You inputted: "<< number << "\n";
      cin.ignore();

      if ( number < actual ) 
         cout<< " You are too low\n";
      else if ( number > actual ) 
         cout<< " You are too high\n";
   } while (number != actual);
              
   cout<< " Congrats you win!!\n";
     
   cin.get();
}

See the FAQ for more information on using rand

Here's the FAQ entry (FAQ > How do I... (Level 1) > Generate random numbers?):
http://faq.cprogramming.com/cgi-bin/...&id=1043284385

And here's Prelude's random number tutorial (FAQ > Prelude's Corner > Random Numbers):
http://faq.cprogramming.com/cgi-bin/...&id=1073086407

>And here's Prelude's random number tutorial (FAQ > Prelude's Corner > Random Numbers):
And here's the updated and vastly improved versions:
http://eternallyconfuzzled.com/tuts/random.html
http://eternallyconfuzzled.com/articles/rand.html
http://eternallyconfuzzled.com/libs/jsw_rand.html

>Perhaps you are referring to the lack of a return 0?
I hadn't thought of that, I bet that's to what Ideswa indeed was referrring. I normally add the return 0; also just for consistency.

>Perhaps you are referring to the lack of a return 0?
I was trying to get him to say it explicitly. Vague good advice is no better than bad advice.