correct usage of strcpy_s

[diego31416]

Greetings,

#include "stdafx.h"#include "codificador.h"


#include <stdio.h>
#include <string.h>
#include <ctype.h>
#include <stdlib.h>


int generaTransformacion(char * original, char * codigo) {


    int originalSize;


    if (original != NULL) {
        /* We obtain dinamically the size of the char */
        originalSize = strlen(original);                            
        /* Given that C does only pass by reference an array, we make a copy of it */
        char *originalDuplicado = (char *)malloc(originalSize * sizeof(char)); 
        strcpy_s(originalDuplicado, original);


        /* By this point, I should be able to check whether the string was copied sucessfully  */
        return strcmp(originalDuplicado, original);
    }
}

In this code, I've got an error in the next line

strcpy_s(originalDuplicado, original);

in which the compiler, VS C++ 2017, complains about a non-existent overload instance method that matches the arguments (char *, char *)

I know the compiler is complaining of not giving in the argument valid pointers of chars but as far as I know, I'm giving exactly those:

int generaTransformacion(char * original, char * codigo) {

char *originalDuplicado = (char *)malloc(originalSize * sizeof(char));

I'm confused with the fact that both lines of code does not represent at least to the function strcpy_s valid char pointers.

Any help or hint would be greatly appreciated.

[john.c]

You need to look up the functions you use. strcpy_s takes three parameters, not two. The second is the size of the destination buffer so that it won't be overflowed. That's the whole point of strcpy_s over strcpy.

[Salem]

1. Name your files as .c, not .cpp. This is so you use a C compiler to compile your C code.
2. You need +1 character in your malloc.
3. You don't call free()

[diego31416]

Thank you for your answer, you were indeed right.