Thread: string problem

I was trying to implement my own "String" class.
I have written the class and the following error occurs.

1.When I create 2 String objects in main function only one string is getting inputted and the other completely ignored

Code:

#include <iostream>#include <cstring>
#include <conio.h>


using namespace std;
enum{MAX=50};
class String
{
	private:
			char S[MAX];
	public:
			String()
			{S[0]='\0';}
			void getString();
			void displayString();			
		
};
void String::getString()
{
	cout<<"Enter String :"<<endl;
	cin.get(S,MAX);
}
 void String::displayString()
 {
 	cout<<S<<endl; 	
 	
 }
 int main()
 {
 	String S,M;
 	S.getString();
 	 M.getString();
 	S.displayString();
 	M.displayString();
	 getch();
 	return 0;
 }

object M is getting ignored..please mention why ..
please provide the correct code if possible.

Remember get() doesn't extract the end of line character from the input buffer, it leaves this character in the buffer for the next operation. If you continue to use get() you'll need to extract this character before the next call to get(). I recommend you consider using getline() instead, and remember that there are two versions of getline() one for a std::string and another for C-strings.


Jim

Jim hit it right on the nail as usual but just to caveat off that if you are using std::getline(std::cin,SomeString,'\n'); and it is skipping it whenever you hit the enter button but in cin.ignore() and that should fix the problem. To give you a better understanding on why this works read:
Using cin to get user input. - C++ Forum

Originally Posted by hk_mp5kpdw

Odd use of an enum.

Yea I agree. The way your using that enum it would be a lot better to have done something like:

Code:

const int MAX = 50;