Thread: Passing a struct to a class

You could make the Character class have a std::vector<Object> member variable named objects, and then provide it with an addObject member function that calls push_back on objects. Or, if this array of objects is supposed to be a universal list of all objects in the game, then you might use a std::vector<Object*> member variable instead.

Originally Posted by AmiPlus

Thank you for the reply.

Could you, please, add the basic class structure for this?

Thank you

Break down what laserlight said piece by piece:

Originally Posted by laserlight

You could make the Character class...

Code:

class Character
{
    ...
};

Originally Posted by laserlight

have a std::vector<Object> member variable named objects, ...

Code:

#include <vector>

class Character
{
    std::vector<Object> objects;
    ...
};

Originally Posted by laserlight

and then provide it with an addObject member function ...

Code:

#include <vector>

class Character
{
    std::vector<Object> objects;
    ...
public:
    void addObject(const Object& item);
};

void Character::addObject(const Object& item)
{
    ...
}

Originally Posted by laserlight

that calls push_back on objects.

Code:

#include <vector>

class Character
{
    std::vector<Object> objects;
    ...
public:
    void addObject(const Object& item);
};

void Character::addObject(const Object& item)
{
    objects.push_back(item);
}

...easy!

The compiler needs to know what an "Object" is before it can generate the necessary code. There is nothing in the code you show which has the struct Obj (what we seem to have taken to calling Object instead) you cited in your original post. The solution therefore is to place the struct definition in your code prior to the class. Also, note that your class works with several std::string data members so you should also remember to include the <string> class.

Code:

#include <iostream>
#include <vector>
#include <string>
using namespace std;

struct Object
{
    string name;
    int num;
    string description;
};
 
class CCharacter{
    string _name, _genre;
    int _inRoom, _status;
    bool _activeCharacter;
 
  public:
    std::vector<Object> objects;
    CCharacter (string,string, int, bool, int);
    string getName () {return (_name);}
 
    void addObject(const Object& item);
 
};
 
void CCharacter::addObject(const Object& item)
{
    objects.push_back(item);
}
 
CCharacter::CCharacter (string name, string genre,int inRoom, bool activeCharacter, int status) {
  _name=name;
  _genre = genre;
 
}

---

Incidentally, you should prefer initialization lists for construction and try to keep in mind const correctness, member functions which do not alter the state of the class they are called upon ("get" member functions for example) should be declared const.

Code:

class CCharacter{
    ...
    string getName () const {return (_name);}
    ... 
};

CCharacter::CCharacter (string name, string genre,int inRoom, bool activeCharacter, int status)
    : _name(name), _genre(genre), _inRoom(inRoom), _activeCharacter(activeCharacter), _status(status)
{

}

Code:

#include <iostream>
#include <vector>

 struct Obj {
    std::string name;
    int damage;
};

class objects {
private:
    std::vector<Obj> Objects;
    
public:
    objects();
    
    void addObject(std::vector<Obj>&);
};

objects::objects() { }

void objects::addObject(std::vector<Obj> &MyObject)
{
    
    Objects.push_back(MyObject); //No matching member function for call 'push_back'

}
int main(int argc, const char * argv[])
{
    objects Myobjects;
    Obj tempObj;
    
    std::vector<Obj>newVector;
    int num=0, count=0,damage=0;
    std::string name;
    
    
    std::cout<<"How many objects do you have?\n";
    std::cin>>num;
    
    while(num!=count)
    {
        std::cout<<"what is your objects name?\n";
        getline(std::cin, name);
        
        std::cout<<"what is your objects damage level?\n";
        std::cin>>damage;
        
        tempObj.name = name;
        tempObj.damage = damage;
        Myobjects.addObject(newVector);
        
        count++;
    }
    
    
    for (auto it = newVector.begin(); it!=newVector.end(); ++it) {
        std::cout<<*it<<std::endl;
    }
    
    return 0;
}

What is wrong here. I decide to so it myself and it is not working.

Originally Posted by jocdrew21

What is wrong here. I decide to so it myself and it is not working.

You are trying to push "vector<Obj> MyObject" into "vector<Obj> Objects". You need to push a single Obj item into the vector, so change your function to accept a single item rather than a container of items.