Thread: the program just stops working. I don't know what is the problem with it! *frustated*

In the following snippet:

Code:

    char *name1;
    char *name2;
    int l1,l2;
    cout<<"enter string1 :";
    cin>>name1;

Where have you allocated memory for those pointers?

Probably more importantly why are you using the character pointers at all? You should be using std::string instead of all those C-strings.

Jim

Code:

char *name1;	char *name2;
	name1=new char[20];
	name2=new char[20];
	int l1,l2;
	cout<<"enter string1 :";
	cin>>name1;

the problem remains the same.... i have to use pointers...and i dont know how to use std::string yet....

Yes, you need to allocate memory in the copy constructor.

In show() you do a strcat(), so you'll need to make sure that the allocated memory is enough to handle that.

You wouldn't have to worry about any of this if you were using std::string. It'd all be much easier!

Code:

#include<iostream>
#include<conio.h>
#include<string.h>
using namespace std;
class name
{


	public:
		int m;
		int n;
		string p;
		string q;
		name()
		{
			}
				name(string mno,string xyz)
				{
				
					p=mno;
					q=xyz;
					}
					name(name &y1)
					{
						string final=y1.p+y1.q;
						cout<<"the final string is :"<<final;
						}
};
main()
{
	string name1;
	string name2;
	int l1,l2;
	cout<<"enter string1 :";
	cin>>name1;
	cout<<"enter string2 :";
	cin>>name2;
	name n1(name1,name2);
	name n2(n1);
	getch();
	return 0;
}

thank u... std::string worked!