Thread: C++ program in need of help!?

Originally Posted by Brian_of_Bozeat

Indentation etc. is personal choice unless you are working with a team (to an agreed format).

Clear indentation is critical to code clarity. Since you are sharing your code and expecting others to read it, it's more than just a personal choice. There is more than one way to clearly indent code, but it needs to be clear where each scope is by the indentation.

If for whatever reason your code has sloppy indentation, you should fix it when posting it for others to read.

Thank you for all the input it has really helped with my code. I have been working on it today and have minimalized my errors. Sadly, I still have a few errors left I can't figure out how to solve.

Code:

 F:\Program6-Arrays2.8.cpp In function `void getInput(int, int)':
47 F:\Program6-Arrays2.8.cpp invalid types `int[int]' for array subscript
 F:\Program6-Arrays2.8.cpp In function `double getLow(double*, int)':
72 F:\Program6-Arrays2.8.cpp name lookup of `counter' changed for new ISO `for' scoping
57 F:\Program6-Arrays2.8.cpp   using obsolete binding at `counter'

Code:

#include<iostream>
#include<cmath>
#include<conio.h>
#include<iomanip> //needed for setw()

using namespace std;

// Function prototypes

void getInput(int,int);
double getLow(double[],int);
double getHigh(double[],int);
double getsum(double[],int);

int main()
{
    const int SIZE=8;
    int num,numbers;
    double sum,lowestscore,highestscore,scores[SIZE];

cout << setprecision(1) << fixed << showpoint;

getInput(numbers,SIZE);

lowestscore = getLow (scores,SIZE);

highestscore = getHigh (scores,SIZE);


sum = getsum (scores,SIZE);

sum -= lowestscore;

sum -= highestscore;
    
cout << "Contestant Receives: " << sum << endl;

cout << "Dropped Low Score: " << lowestscore << endl;

cout << "Dropped High Score: " << highestscore << endl;

system("pause");

    
    
}
void getInput(int numbers,int size)
{
     int index;
     
     for(index = 0; index <= size - 1;index++)
     {
 
  cout << "Enter Judges Score #" << (index+1) << ":";
  cin >> numbers[index];
}
}
double getLow(double array[], int size)
{
       double lowest;
       
       lowest = array[0];
       
for(int counter = 1; counter < size ; counter++)
{
        if( array [counter] < lowest)
            lowest = array [counter];
return lowest;
}
    
    
double getHigh( double array[] , int size);
{
    double highest;
    
    highest = array[0];
    for(counter = 1; counter < size ; counter++)
{
    if(array [counter] > highest)
    highest = array [counter];
    
    return highest;
}
double getsum(double array[],int size);
{
       double sum=0;
       for(int count = 0 ;count < size ;count++)
       sum += array [count];
       
       return sum;
}
}
}

I've personally noticed that when code posted on here has very poor formatting that it is the direct cause of the problem about 50% of the time.

In this instance I can yet again see that it is the direct cause of a compilation error.

I wonder how much time an automatic first response that asked the poster to first indent their code properly would save...

Originally Posted by manasij7479

Yes..but the OP refuses to try fixing it ..

Code:

for(int counter = 1; counter < size ; counter++)
{
        if( array [counter] < lowest)
            lowest = array [counter];
return lowest;
}

Then we can simply stop helping!
Indentation is basics of basics, and also a sort of etiquette. You don't go around asking people to do certain things.
If you ask someone to wash your clothes, you can at least make sure they don't stink!