My last incorrect code needs some help!!!

[dotrunghai82]

And this is the last incorrect code

Question:

Write a program that:
- Opens up each filename in argv[] for reading, starting from the second arg
ument
- - For each file, if the open fails, print, to stderr, the name of the file
that failed and an error message
- - - For each file that succeeds,
- - - Print out each line in the file to stdout, if that line contains the s
tring in argument 1
- - - At the front of the line, also print the name of the file it came from
, and the line number, separated by colons
- - - Close it
- Uses function prototypes:
- - int partial_match( char*, char* );
- - int find_string( char*, char* );

Example:

file.txt:
hello
world
this
is a test

file2.txt:
goodbye
world
this
is a test
so is this
and so on
we blissfully go

./prog is none.txt file.txt file1.txt
Error: could not open none.txt
file.txt:3:this
file.txt:4:is a test
file2.txt:3:this
file2.txt:4:is a test
file2.txt:5:so is this
file2.txt:7:we blissfully

- Note that the error was printed to stderr rather than stdout

- Note that this essentially only printed lines with "is" in them, from seve
ral files
Here's the pseudocode:
main:
for as long as we have arguments
open a file with filename of the current argument
if it opens successfully
for each line in the file
if it contains the word we're looking for
print the line
close the file
otherwise
print an error

contains:
for as long as we have non-null characters in a string
if the string starting from the current location partially matches the w
ord
true
by the end, if we never found it, false

partial-match:
for as long as we have characters in the word we're searching for
if the string's current character doesn't match the corresponding word's
current character
false
by the end, if we never found a discrepancy, true

Here's my incorrect code:

#include <stdio.h>
int partial_match (char* string1, char* string2);
void find_string (char* find_this, char* within_this);
int main (int argc, char** argv)
{
   File* funny;
   int i = 2;
   char buffer [1024];
   for (i=2; argv [i] != '\0'; i = i + 1)  
  {  
    funny = fopen (argv [i], "r");
    if (funny != NULL)
      {
         while (fgets (buffer, 1024, funny)!= NULL)
           { 
             find_string (argv [1], argv [i]);
           }
              fclose (funny);
           }
             fprintf (stdout, "no argument!\n");
           }
void  find_string (char* find_this, char* within_this)
{
int j;
for (j = 0; within_this[j] != '\0'; j = j + 1)
   {
if (find_this[j] == &within_this[j] )
     {
         return 1;
     }
         return 0;
   }
}

int partial_match (char* string1, char* string2)
{
  in m;
  for (m = 0; string1[m] != '\0'; m = m+1)
       {
          if (string1 [m] != string2 [m])
            {
                return 0;
             }
                 return 1;
        }
}

That's it! Thanks for your help!!!

[quzah]

You know, we're not here to do everything for you. Why is your code incorrect? At which point are you having problems? Instead of just pasting in all of your homework problems as they were provided to you, provide something useful. What part doesn't work? I suspect this is a "here's some code that doesnt' work, it is you the student's job to fix it", and you're trying to take the lazy way out.

Why doesn't it work? What part? What part works? Learn to debug. You may not always have a debugger (us) handy.


Quzah.

[fnoyan]

Well maybe reading the forum guidelines may be useful before posting!

http://cboard.cprogramming.com/annou...t.php?f=4&a=39

And also, I would post some compiler error/warning messages or something like that instead of the whole code and question itself (as quzah said).

[dwks]

You're missing a 't' here:

in m;

Your case is wrong here:

File* funny;

I don't think this does what you want:

if (find_this[j] == &within_this[j] )

[ssharish2005]

U need a proper alignment in your code. It is very difficult read a code, otherwise . Indent your code first, which make a bit readable

ssharish2005

[manutd]

It is not badly aligned, it just needs a bit of whitespace.

[dwks]

It is badly aligned (or indented). This program "just needs a bit of whitespace":

int main(void) {
 int x, y, z, a, b, c;
 double h, j, k, l, z;
 if(x && y && z || h+1) {
  printf("%i%i%i%i%i\n", x, x, x, x, x);
 }
 //...
}

Look at this function, for instance. It's indentation isn't that good.

int main (int argc, char** argv)
{
   File* funny;
   int i = 2;
   char buffer [1024];
   for (i=2; argv [i] != '\0'; i = i + 1)  
  {  
    funny = fopen (argv [i], "r");
    if (funny != NULL)
      {
         while (fgets (buffer, 1024, funny)!= NULL)
           { 
             find_string (argv [1], argv [i]);
           }
              fclose (funny);
           }
             fprintf (stdout, "no argument!\n");
           }

[manutd]

Yes, but that indentation doesn't really make a difference in the readibility of this code. It's pointless to argue about, anyway.

[swgh]

manutd I disagree, having well indented code can help improve readability and makes code easier to debug

[Xero]

And to add, it will greatly boost development time when working in groups.
(Since it has good readability)

[manutd]

Yes, I am saying that indentation is important, but in this code the indentation is not that bad.