Thread: what's wrong with these?

i try to make a program that will tell the user if there is a 0 in his input but why won't it run the way i want it to?

Code:

#include <stdio.h>
#include <conio.h>
int main(){
    int num[10];
    int i= 0, cnt=0;
    printf("Give me 10 numbers that are greater or equal to 0\n");
    for(i=0; i<10; ++i){
             scanf("%d", &num[i]);
             num[i] = i;
             }
    for(i=0; i<10; ++i)
             if(num[i] == 0)
                 printf("Yes, there is a 0\n");
             else
                 printf("No, there is no 0\n");
    getch();
    return 0;
}

You're assigning the counter variable to the array.


Quzah.

You realize that integers are more than one character long, at times, right? Therefor, you know that "3401" is one integer, right? What you should be doing is scanning characters and look for '0'.

Originally Posted by quzah

You're assigning the counter variable to the array.

Also that.

the brackets don't work...
i want it to output only one sentence and even though there is no 0, it outputs "Yes, there is a 0"

how can i scan characters?

Read the FAQ on reading a line of text.


Quzah.

i still don't get it you know...

Read <--- CLICK CLICK

Now you know how to read a line from the user. Since you already know how to read each element of an array, it shouldn't be hard to figure out how to read each character in the array and compare it to '0'.


Quzah.

Code:

getch();

http://faq.cprogramming.com/cgi-bin/...&id=1043284385

Originally Posted by esbo

This any better? Note the line I commented out!!

Not by much! The scanf() should be avoided, I'd say.

However, I do believe I misunderstood the point of this program to find digits equal to zero, not numbers. I guess I thought that since the latter just seems illogical.

You'll probably want to have the second for loop set a flag if it encounters a 0 in the array, which you can check after the loop is finished. As written, if the user enters more than one 0 it will print "Yes, there is a 0" for each one.

Code:

0 0 0 0 0 0 0 0 0 0
Yes, there is a 0
Yes, there is a 0
Yes, there is a 0
Yes, there is a 0
Yes, there is a 0
Yes, there is a 0
Yes, there is a 0
Yes, there is a 0
Yes, there is a 0
Yes, there is a 0

The variable cnt is unused. (Turning on compiler warnings would probably find this for you. For gcc add -W -Wall to the command line/compiler options.)

that's right.. i get an answer for each one even though i only want ONE answer.

So you know how to fix it, right? Set a variable, say contains_zero, to 1 in the loop instead of printing a message, and then at the end of the loop print a message depending on the value of contains_zero.