Thread: Errors!

Hi I have 2 questions:

First question:

Code:

void cp_even()
{	int j;
	j=0;
	int i,a[6],b[j],*ptra, *ptrb;
	printf("Enter SIX values:");
	
	for(i=0; i<=5; i++)
	{
		scanf("%d",&a[i]);
		if(a[i]%2==0)
		{
			b[j]=a[i];
			j++;
		}
	}
	
	ptra=&a[0];
	ptrb=&b[0];
	
	............................... end of the code
}

My problem with the bold font in the code, I recieve this missage:
: error C2057: expected constant expression
I don't know why it says that; j=0 is constant! (this works in java)

Second question:

Code:

void upperCase(char *ptr)
{
	//ptr=&string[0];
	while(*ptr!='\0')
	{
		if(islower(*ptr)) 
			*ptr=toupper(*ptr);
		ptr++;
	}
}
void p8()
{
	char string[3];
	printf("Tybe a string in lower case");
	gets(string);

	upperCase(string);//change to *ptr
	printf("The string in uppercase: %s",string);
}

The code works fine, BUT after displaying the out put on the screen I recieve this message:

Debug error!
......... some paths
Run-Time check Failure #2 - stack around the variable 'string' was corrupted.....

Thankx

1. > It works in Java.
lol.
Okay well, to repeat the compiler, j is not constant at all and even if you used the const keyword, you can only use a variable to initialize arrays in C99. It's also impossible to allocate a zero-length array.


2. I blame gets for this. Use fgets.

Originally Posted by citizen

2. I blame gets for this. Use fgets.

fgets takes more than one arguments and I don't want that

Yes you do. gets is evil.

Originally Posted by citizen

Yes you do. gets is evil.

!!!!

Originally Posted by laserlight

Why gets() is bad

So where is the problem!

Originally Posted by citizen

1. > It works in Java.
lol.
Okay well, to repeat the compiler, j is not constant at all and even if you used the const keyword, you can only use a variable to initialize arrays in C99.

I thought you could use

Code:

const int i = 10;
int j[i];

Actually, I'm certain you can

It works sand_man , but I recieve this message:
: error C2105: '++' needs l-value

for this code:

Code:

for(i=0; i<=5; i++)
	{
		scanf("%d",&a[i]);
		if(a[i]%2==0)
		{
			b[j++]=a[i];
			//j++;
		}
	}

I don't know if I can do that, or what I did is correct, again I am new in learning C