Thread: Run-time error

I want to write a program to remove the first smallest number that i input..

input 6 integer from keyboard, they are 12 15 2 16 2 4

how can i amend the program that can remove the first '2' and shift ithe first '2' 's right hand side number to left, thanks.

Output is : 12 15 16 2 4

Code:

void RemoveFirstSmallest(int A[], int n) 
//A is an array containing n integers
{
	int i;
	int min_value = A[0];
	int id_min = 0;

	for (i=1; i<n;i++)
	{
		if (A[i] < min_value) 
		{
			min_value = A[i];
			id_min = i;
		}
	}
		for (i=id_min;i<n-1;i++)
		{
			A[i] = A[i+1];
		}
}

if i input the number '2' twice...how can the program to remove the first '2' that i input??Thanks

and also the last number in A[] doesnt get left shifted

Are you havng a problem with runtime error or your just having a problem making your program work?

Apart from the things mentioned above, the code seems ok.

when 12 15 2 16 2 4 is input.

At the third position (i=2, for 0 to <n) id_min becomes =2.

Now when we encounter the second time, we have a close that a[i] < minvalue, which will not be true. So id_min will remain to be 2 (correct value). So we just shift after this.

Originally Posted by itsme86

That code is not the source of your run-time error. The first loop should run from 0 to n instead of 1 to n, but otherwise that code is correct. Maybe the problem is in your input method?

1 to n is fine because they used the 0 value as the inital min value.

Originally Posted by loko

and also the last number in A[] doesnt get left shifted

It appears that it does get shifted, however it also remains in the last spot. So you'll need to do something to ignore it later.

Originally Posted by Thantos

It appears that it does get shifted, however it also remains in the last spot. So you'll need to do something to ignore it later.

Thats what i meant