please, Urgent help about functions

**louis_mine** · 09-17-2004

I have been working with functions for a few days, and i consider i have some knowledgel, however, i try to make the function to print a certain figure, but it wont do it, I have no Idea why, i think the program should run, only for the menu i am creating of course

#include <stdio.h>
#include <conio.h>
void trhueco (int);

void main()
{
int menu, opcion, a, b, c;
printf("\choose");
printf("\n Empty triangle");
scanf("%d", &menu);

switch (menu){
case 1:
printf("put the number of lines");
scanf("%d", &a);
trhueco (a);
break;
}

}
void trhueco (int reng){
int colu, c, d, e;

d=reng;
for (c=1; c<=d; c++){

for (colu=1; colu<=c; colu++)
{ if ( colu!=1 && colu !=c)
printf(" ");
else
printf("*");
}

The program runs, but it prints nothing but *** in a row, and not the figure:

*
**
* *
* *
* *
* *
* *
********

so if anyone could find any mistakes altering my program I would be very thankful

**prog-bman** · 09-17-2004

well use [ code] tags please and also void main?????????????????????
I am not gonna look at the rest until i see some tags

**Maragato** · 09-17-2004

Dude I haven't fixed up your code, but I've cleaned it from unused variables, and some minor mistakes, I would suggest you see how it is looking now and try to fix it up, or at least post the order of the exercise you are trying to do.

Duh, forgot to post the code....

Code:

#include<stdio.h>

void trhueco (int);

int main ()
{
	int menu,a;
	
	printf ("\nchoose");
	printf ("\n Empty triangle");
	scanf ("%d", &menu);

	switch (menu)
	{
	case 1:
		printf ("put the number of lines");
		scanf ("%d", &a);
		trhueco (a);
		break;
	}
	return 0;
}

void
trhueco (int reng)
{
	int colu, c, d;

	d = reng;
	for (c = 1; c <= d; c++)
	{

		for (colu = 1; colu <= c; colu++)
		{
			if (colu != 1 && colu != c)
				printf (" ");
			else
				printf ("*");
		}
	}
}

**principii** · 09-17-2004

A little bit off-topic, but I've noticed in the code that he just made more readable, he did:

Code:

return-type
func-name (type arg)
{
    ...
}

Instead of this:

Code:

return-type func-name(type arg)
{
    ...
}

What is the advantage of this style? It seems rather difficult to me, but I've seen it in other places, too.

**Hunter2** · 09-17-2004

Advantage: Function name isn't 'indented' from the return type, therefore potentially easier to read
Disadvantage: Takes an extra line, seems unintuitive for people who are used to seeing it the other way (looks like it's been decapitated and had its body parts stacked in a pile).

**Prelude** · 09-17-2004

>What is the advantage of this style?
It makes searching for a function definition easier with tools such as grep. As long as the convention that declarations are "normal" holds, searching for the function name at column zero will return the definition because the declaration does not have the function name at column zero and because any call to the function will supposedly be indented for readability.

In the modern age of programming (the present, in case you were wondering

), this style really isn't necessary and is a throw back from times of dumber code viewing tools. When you have a database of function declarations and definitions readily available and often built into the development environment, formatting your code for the sole purpose of grepping seems a little silly.

**bideyore** · 09-18-2004

i don't quite understand what u wanna do ,louis_mine ,so i just guess that u wanna print
out a triangle .here i just did slight modification:

Code:

void
trhueco (int reng)
{
                 int colu, c, d;

                d = reng;
                for (c = 1; c <= d; c++)
                {

                                 for (colu = 1; colu <= c; colu++)
                                 {
                                                if (colu != 1 && colu != c)
                                                                printf (" ");
                                                else
                                                                printf ("*");
                                  }
                                  printf("\n");      /*ADD THIS TO UR PROGRAME*/
                  }
}

after that u can get an empty right-angled triangle.

besides,i don't quite care bout the different function styles.Just use the one that makes u feel comfortable

Thread: please, Urgent help about functions

Thread Tools

Search Thread

Display

please, Urgent help about functions

Similar Threads

Void Functions Help

Functions and Classes - What did I do wrong?

calling functions within functions

Factory Functions HOWTO

Shell functions on Win XP