Simple loop/array problem

[Chimpsag]

I have the following code, which basically populates an array, and then cheks to see if one number is a multiple of another....

I don't receive any errors, the program simply crashes as soon as it enters the "findprimes" function:

	// populate array (inside main)
	for(i=0;i<=MAX;i++)
	{
		numbers[i] = i;
	}

// THIS FUNCTION CAUSES THE PROGRAM TO CRASH...
void findPrimes(int numbers[])
{
	int a, b;

	for(a=0;a<=MAX;a++)
	{
		for(b=0;b<=MAX;b++)
		{
			if(numbers[b]%numbers[a] == 0)
				numbers[b] = 0;
		}
	}
}

Help is appreciated.
Thanks.

[Magos]

if you defined numbers as numbers[MAX], then you will try to read/write outside the array bounds.

Either define numnbers[MAX + 1] or have the for loop go in the interval (0 <= x < MAX) instead of (0 <= x <= MAX).

[Chimpsag]

I changed that part but the program continues to crash...

[Dave_Sinkula]

	// populate array (inside main)
	for(i=0;i<=MAX;i++)
	{
		numbers[i] = i;
	}

// THIS FUNCTION CAUSES THE PROGRAM TO CRASH...
void findPrimes(int numbers[])
{
	int a, b;

	for(a=0;a<=MAX;a++)
	{
		for(b=0;b<=MAX;b++)
		{
			if([B]numbers%numbers[a] == 0)
				numbers[b] = 0;
		}
	}
}

Let's be more careful with division and zeros.

The result of the / operator is the quotient from the division of the first operand by the second; the result of the % operator is the remainder. In both operations, if the value of the second operand is zero, the behavior is undefined.

Some thoughts...

#include <stdio.h>

#define MAX 100

void findPrimes(int numbers[])
{
    int a, b;
    for ( a = 2; a < MAX; a++ )
    {
        for ( b = 2; b < a; b++ )
        {
            if ( numbers[a] % b == 0 )
            {
                numbers[a] = 0;
            }
        }
    }
}

int main(void)
{
    int i, numbers[MAX];
    for ( i = 0; i < MAX; i++ )
    {
        numbers[i] = i;
    }
    findPrimes(numbers);
    for ( i = 0; i < MAX; i++ )
    {
        if(numbers[i])
        {
            printf("%d\n", numbers[i]);
        }
    }
    return 0;
}

[Hammer]

>for(i=0;i<=MAX;i++)
Are you sure you didn't mean
>for(i=0;i<MAX;i++)