Thread: Function returning pointers issues

Greeting
I'm trying to write a single function that returns the average value and stores the count of the elements greater than the average value
into the parameter named greater, as defined in the following prototype:

float over_Avg(int v[], int n, int *greater);

my code is the folowing

Code:

#include <stdio.h>
#include <stdlib.h>




float avgVect(int v[], int n,int *greater)
{
int i;int count=0;
   int s=0;
   float average;
   greater=&count;
   for(i=0;i<n;++i)
    s=s+v[i];
    average =s/n;
     for(i=0;i<n;++i)
     {
         if (v[i]>average)
        count++;


     }


    return average;


}
int main ()
{
  int v[] ={1,0,3};
int *ptr;
  float resul;
  resul= avgVect(v,3,ptr);
  printf("%f %d",resul,(*ptr));
}

and as you might have understood it's not working so what's wrong?

any hint would be highly appreciated!!

Best

greater = &count.

What's the scope of count??

That's a hint. See if you can work it out.

OK let me explain a bit more.

You have passed the address of a variable that no longer exists because it has gone out of scope back to main.

Code:

void func( int* ptr)
{
   int count;
   ptr = &count;
} // count dies here, it no longer exists, it has ceased to be, it has joined the choir invisible....

Originally Posted by Hobbit

OK let me explain a bit more.

You have passed the address of a variable that no longer exists because it has gone out of scope back to main.

Code:

void func( int* ptr)
{
   int count;
   ptr = &count;
} // count dies here, it no longer exists, it has ceased to be, it has joined the choir invisible....

He didn't "pass" anything at all. He simply set greater equal to the address of count. greater also stops existing at the end of the function.

Well yeah it's late. 3.15 am and upstairs is still partying. This is wrecking my job. Thank God I'm on forced holiday. No contract at the mo.

OK I took pity on you, you've had a go. Here's the fixed code.

Code:

#include <stdio.h>


float avgVect(int v[], int n, int *greater)
{
	int i;
	int s = 0;
	float average;
	*greater = 0;


	for (i = 0; i<n; ++i)
		s += v[i];
	average = (float)s / n;
	for (i = 0; i<n; ++i)
	{
		if (v[i]>average)
			++*greater;
	}
	return average;


}
int main()
{
	int v[] = { 1,0,3 };
	int count;
	float resul;
	resul = avgVect(v, 3, &count);
	printf("%f %d", resul, count);
	return 0;
}

count in your function was unnecessary, just zero *greater, and you were doing integer division so to avoid that we cast one of the numbers in the average calculation to a float. You were nearly there. The increment should have been ++*greater not ++count.