Thread: Simple yatzee game

I made a function generating 5 random numbers into an array. After that I made an multi-dimensional array and stored dices in six diffrent char. Now im trying to use a switch case to decide which 5 dices to print out depending on which 5 numbers was generated into the first array.

Code:

#include <stdio.h>
#include <stdlib.h>


void kastar (int kast2[5]);

void generate_random_numbers(int kast2[]);

int main()
{

int kast2[5];




srand((unsigned) time( NULL ) );

generate_random_numbers(kast2);




kastar(kast2);



    return 0;
}

void generate_random_numbers(int kast2[])
{
    int k;
    for(k=0;k<5;k++)

kast2[k] = rand() % 6 + 1;


}



void kastar (int kast2[5])
{
    int k, rad,kolumn;

    char one [3][6]={{' ',' ',' '},{' ','*',' '},{' ',' ',' '}};
    char two [3][6]={{' ',' ','*'},{' ',' ',' '},{'*',' ',' '}};
    char three[3][6]={{'*',' ',' '},{' ','*',' '},{' ',' ','*'}};
    char four[3][6]={{'*',' ','*'},{' ',' ',' '},{'*',' ','*'}};
    char five [3][6]={{'*',' ','*'},{' ','*',' '},{'*',' ','*'}};
    char six [3][6]={{'*',' ','*'},{'*',' ','*'},{'*',' ','*'}};
for(rad=0;rad<3;rad++)
    {
for(kolumn=0;kolumn<6;kolumn++)
switch(kast2[k])
{
case 1: printf("%c", one   [rad][kolumn]); break;

case 2: printf("%c", two   [rad][kolumn]); break;

case 3: printf("%c", three [rad][kolumn]); break;

case 4: printf("%c", four  [rad][kolumn]); break;

case 5: printf("%c", five  [rad][kolumn]); break;

case 6: printf("%c", six   [rad][kolumn]); break;

}

    }

}

My program just crash whenever I start it.

This is what I get when trying to compile your code with the warnings turned on (-Wall):

Code:

test.c: In function ‘kastar’:
test.c:41:16: warning: ‘k’ may be used uninitialized in this function [-Wmaybe-uninitialized]
    switch(kast2[k]) {
                ^

I bet that's what crashes your program.