Thread: Help with printing .txt from an array

Hello all, I'm having a problem with the code below. What I'm trying to do is take a .txt file, put the digits and words into separate arrays, and then print it to the screen. The printf in the 'while' loop works fine. However the printf in the 'for' loop does not. I am able to print the digits just fine, but the only words I get is 'six', which is printed 6 times. I can't figure out why. Any sage advice would be nice. (the .txt is in the comments)

Code:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
/* 1 one
   2 two
   3 three
   4 four
   5 five
   6 six
*/
int main()
{
    FILE *myfile;
    char line[121];
    char *item;
    int reccount=0;
    int temp_num[10];
    char *temp_name[10];
    int x;
    myfile=fopen("C:\\Users\\eric\\Desktop\\c_code\\number_exp.txt","r");
    while(fgets(line,120,myfile))
    {
       printf("%s",line);
       item=strtok(line," ");
       temp_num[reccount]=atoi(item);
       item=strtok(NULL," ");
       temp_name[reccount]=item;
       reccount++;
    }
    fclose(myfile);
    for(x=0;x<reccount;x++)
      printf("%i %s",temp_num[x],temp_name[x]);
    return 0;
}

Hi vart, thanks for taking the time to help me. I think I've done as you suggested, as noted in the revised code below. However I'm getting another set of strange results. The 'while' loop is still printing fine. However the 'for' loop isn't working still. The numbers print, but the words are prefixed with the first letter of each word. I've commented it below the main program. I've tried various declarations, referencing, and dereferencing of pointers, and getting rid of them all together to no avail. I'm certain I'm doing something wrong, but what?

Code:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
/* 1 one
   2 two
   3 three
   4 four
   5 five
   6 six
*/
int main()
{
    FILE *myfile;
    char line[121];
    char *item;
    int reccount=0;
    int temp_num[10];
    char temp_name[10];
    int x;
    myfile=fopen("C:\\Users\\eric\\Desktop\\c_code\\number_exp.txt","r");
    while(fgets(line,120,myfile))
    {
       printf("%s",line);
       item=strtok(line," ");
       temp_num[reccount]=atoi(item);
       item=strtok(NULL," ");
       strcpy(&temp_name[reccount],item);
       reccount++;
    }
    fclose(myfile);
    for(x=0;x<reccount;x++)
      printf("%i %s",temp_num[x],&temp_name[x]);
    return 0;
}
/* 1 one
   2 two
   3 three
   4 four
   5 five
   6 six
   1 ottffsix
   2 ttffsix
   3 tffsix
   4 ffsix
   5 fsix
   6 six
*/

Declare temp_name[10][10] so that you have an array of ten strings that are each up to 9 characters long. Get rid of the ampersands before temp_name when you are scanning and printing. If you are concerned with overflowing the strings, use strncpy() instead of strcpy().