it compiles but it tells me segmantation fault any help?Code:#include <stdio.h> #include <stdlib.h> int getsize(void){ int counter=0; FILE *testa; testa=fopen("error.txt","r"); char *c; while(fscanf(testa,"%s",c)!=EOF) counter++; printf("%s",c); return counter; } int main(){ int size; size=getsize(); return 0; }
the txt file contains numbers with a space of each one
For starters, indent your code. Next, you should check if fopen succeeded, and eventually fclose if it did. Oh, and if you want to read a string, you need to allocate space for it first. (Plus naming a string c is quite misleading: I think to think it is a character rather than a string.)
Look up a C++ Reference and learn How To Ask Questions The Smart WayOriginally Posted by Bjarne Stroustrup (2000-10-14)
fopen is succeed even if i put fclose still the same problem
also c is a pointer of string so like i know it can still point to string even if i do not malloc
At the moment there is simply no space allocated, with or without malloc.
Look up a C++ Reference and learn How To Ask Questions The Smart Way
so if i still want to keep the pointer of string how can i solve the problem
i mean with minimum changes
What? Without malloc? Do you understand how pointers work? If it's used uninitialized, it most likely points to zero, or a garbage value left in the stack from previous use. Trying to shove data into these segments will fail unless you get lucky enough to have it pointing to an unused segment.
Either you have to use a stack array:
or suck it up and use malloc:Code:char c[BUFSIZ];
replacing BUFSIZ with however much you need. Also, if you're trying to read numbers, why are you fscanf()'ing for space-delimited words?Code:char *c = malloc(BUFSIZ);
