problem in if statement

[Rian]

I'm a beginner on C programming so some of you might find the code I'm writing is silly. I have been working for a simple program that ask user for 3 numbers, and provide results such as sum, average, product, smallest and largest number. I come up with this:

#include<stdio.h>#include<stdlib.h>


int main()
{
    int a;
    int b;
    int c;
    
    printf("Enter number 1: ");
    scanf("%d", &a);
    
    printf("Enter number 2: ");
    scanf("%d", &b);
    
    printf("Enter number 3: ");
    scanf("%d", &c);
    
    printf("\nSum: %d \n", a+b+c);
    
    printf("Average is: %d \n", (a+b+c)/3);
    
    printf("Product is: %d \n", a*b*c);
    
    if(a<b && a<c)
    {
        printf("Smallest number is: %d \n", a);
    }
    
    else if(b<a && b<c)
    {
        printf("Smallest number is: %d \n", b);
    }
    
    else
    {
        printf("Smallest number is: %d \n", c);
    }
    
    if(a>b && a>c)
    {
        printf("Largest number is: %d \n", a);
    }
    
    else if(b>a && b>c)
    {
        printf("Largest number is: %d \n", b);
    }
    
    else
    {
        printf("Largest number is: %d \n", c);
    }
    
    system("pause");
    return 0;
}

The problem is whenever I put the same number in number 2 and 3, it automatically choose number 3 as the smallest and the largest number. What am I missing here? Thanks!

[CommonTater]

Sit down with a pencil and paper and follow your variables through the program... step by step... you'll find it.

Troubleshooting is such a basic programming skill, you should be glad of the opportunity to work on it.

[rmatze]

Check your logic for this part:

else if(b<a && b<c)    {
        printf("Smallest number is: %d \n", b);
    }
     
    else
    {
        printf("Smallest number is: %d \n", c);
    }

and the same this for the largest number. It's doing exactly what you are telling it to do.

[TheBigH]

You'll also find the average is wrong. Try it for 3,3,4. The output will be 3 rather than 3.33333333 because you are doing integer division.

[Rian]

Check your logic for this part:

else if(b<a && b<c)    {
        printf("Smallest number is: %d \n", b);
    }
     
    else
    {
        printf("Smallest number is: %d \n", c);
    }

and the same this for the largest number. It's doing exactly what you are telling it to do.

Okay I found my mistake. When I put a=2, b=2, c=3 it will not print a or b as the smallest because a<b and a<c is not true. Do I need to learn other operator to solve this?

[Rian]

Sit down with a pencil and paper and follow your variables through the program... step by step... you'll find it.

Troubleshooting is such a basic programming skill, you should be glad of the opportunity to work on it.

I'm doing it now

[Rian]

You'll also find the average is wrong. Try it for 3,3,4. The output will be 3 rather than 3.33333333 because you are doing integer division.

my bad, my knowledge of programming language is still very limited. Let me know if you have other solution

[stahta01]

I would try <= instead of < and see if it works.

Note: My logic would be very different. I would have a smallest and largest variable that I set to the smaller/larger value.

Tim S.