Thread: append queue

hello everyone,im trying to make a simple program run but i cant seem to make it work,i have been working on this for the whole day :\ any hand

Code:

#include<stdio.h>

struct Node{
	int Data;
	struct Node *Link;
};
typedef struct Node *QueuePointer;

void append(QueuePointer *Head,QueuePointer *Tail, int Num)
{
	QueuePointer NewNode;
	NewNode=(QueuePointer)malloc(sizeof(struct Node));
	NewNode->Data=Num;
	NewNode->Link=NULL;
	if (Tail==NULL)
		*Head=NewNode;
	else
		(*Tail)->Link=NewNode;
		*Tail=NewNode;
}

void main()
{
	QueuePointer Tail;
	int value,a,b,c;
	int x;
	Tail=NULL;
	clrscr();

	for(b=1; b<6; b++)

{
	printf("Enter Values to Append: ");
	scanf("%d",&Tail);
}

{
	for(a=1; a<6; a++)
	append(&Tail);
	while(Tail!=NULL)
	{
	printf("%d\n",&Tail);



}
}
	getch();
}

We have a beautifully-written, perfectly-indented append function. And then we have the main function. Let's look at that briefly:

1. There is no such thing as void main.
2. Nor is there such a thing as clrscr.
3. You cannot write directly into a QueuePointer variable using scanf, and especially when you tell scanf that the variable is an int ("%d").
4. You read six times, but into one variable, so the first five just go away.
5. You then try to append the same number six times.
6. If you look at the append function up top, you will see that you need to give it two pointers-to-QueuePointers and an int. This is one more QueuePointer than you even have.
7. Your while loop has an exit condition, which is good; however, you make no attempt to make the exit condition true inside the loop, so you will never exit.
8. No such thing as getch.
9. Indentation!

I guess that's a start.

uhm...what do you mean by this?sorry i have bad english

There is no such thing as void main.
Nor is there such a thing as clrscr.
No such thing as getch.

"No such thing" = "does not exist".

ohh i understand what that mean buttttttttt,...

so this means i dont have to use void main?clrscr?ang getch?

but after i input the value i want to clear the screen :\

Cprogramming.com FAQ > main() / void main() / int main() / int main(void) / int main(int argc, char *argv[])

Cprogramming.com FAQ > Clear the screen?

Cprogramming.com FAQ > Stop my Windows Console from disappearing everytime I run my program?

Originally Posted by stitches

ohh i understand what that mean buttttttttt,...

so this means i dont have to use void main?clrscr?ang getch?

but after i input the value i want to clear the screen :\

The correct minimum C program is...

Code:

int main (void)
 {

    return 0;  
}

Main returns an integer value to the operating system. In most cases this is either 0 or an error level.

Your compiler should be telling you it can't find a function named ... clrscr() or getch() ... pay attention to your compiler's error and warning messages!

Both clrscr() and getch() are non-standard functions that originated with the wildly outdated Borland Turbo C compiler that nobody in their right mind would be using anymore.

Also note that repeatedly clearing the screen can actually be disorienting to an operator, as can too many on-screen messages. If you have them doing repeated entries, let them scroll up the screen so that, should they become distracted, they can easily discover where they left off. Also don't try to keep the screen full of stuff, print only the essential information so as not to distract your operators. (Just because you can do something, does not mean you should)

Code:

#include<stdio.h>

struct Node{
	int Data;
	struct Node *Link;
};
typedef struct Node *QueuePointer;

void append(QueuePointer *Head,QueuePointer *Tail, int Num)
{
	QueuePointer NewNode;
	NewNode=(QueuePointer)malloc(sizeof(struct Node));
	NewNode->Data=Num;
	NewNode->Link=NULL;
	if (Tail==NULL)
		*Head=NewNode;
	else
		(*Tail)->Link=NewNode;
		*Tail=NewNode;
}

main()
{
	QueuePointer Tail,Head;
	int value,b;
	int x;

	Tail=NULL;



	for(b=1; b<6; b++)


	{
	printf("Enter Values to Append: ");
	scanf("%d",&Tail);
	}


	printf("
%d",Tail);



	getch();
}

i managed to display the only 1 value i entered...why is this?

Originally Posted by stitches

i managed to display the only 1 value i entered...why is this?

Scroll back up and read message #2 ... just because there's no code sample in it does not mean it has no meaning.

(Hint: There is no point asking a question if you are just going to ignore the answers.)

how would i learn if i wont get the concept on how to display it.I am already working out on the help you guys are giving me but i cant seem to figure it out, I usually understand through example,not through lecture.application over theory, I am also doing my part here to try and understand what you guys are sharing to me and its getting frustrating how ive been working here without getting results,not everyone is alike that can easily understand complicated theories :\ and we came from different instructors