Thread: Newbie needs a little help!

Hey guys, so I started to learn a little C from numerous different sources and Iv'e hit a little "bump". When following a simple tutorial of how to make a average calculator with 5 inputs I decided I wanted to make it a little more advanced, and have a unlimited amount of inputs. I know what I have done wrong(As pointed out in "comments" in the code), but not sure how to correct it. Could you guys have a little look and in very basic terms tell me how to fix it, thanks.

Code:

 #include <stdio.h>
#include <conio.h>

int main(void)
{
         int loopcount;
         int numbers;
         int total;
         int average;
         int numtoav;
         /* ^^ Number's to average */
         int mainvar;
         total=0;
         loopcount=0;
         
         {
                printf("How many numbers do you want to average?");
                scanf ("%d, &numtoav");     
                     
                     }
         
         while(loopcount< &numtoav){
         /* Problem's persisst here ^^ */   
          printf ("Enter the numbers you want to average");
          scanf("%d", &numbers);
          total = total + numbers;
          loopcount=loopcount+1;  
                          
         }         
         average = total/&numtoav; 
         /*Aswell as here ^^ */
printf("The average of your numbers is: %d", average);
                       
         getch ();
         }

Also any tips on bad coding etiquette would be also appreciated.

scanf takes a reference to the integer numtoav. But otherwise you should use it as an ordinary integer.

Code:

while(loopcount < numtoav) {
...and...
average = total / numtoav;

Thank you, it runs now, but it still doesn't work fully, CMD looks something like this (Area between *'s is user input)

How many numbers do you want to average?*5*
Enter the numbers you want to average*2 6 7 9*
Enter the numbers you want to averageEnter the numbers you want to averageEnter
the numbers you want to averageEnter the numbers you want to averageEnter the
numbers you want to average

Also any tips on bad coding etiquette would be also appreciated.

Get your indentation and whitespace under control. Consistency makes it SO much easier to read and spot errors.

Originally Posted by mike65535

I don't understand this:

Are you attempting to enter 2 6 7 9 (four numbers with spaces) on one line of user input before a return?

The program wants each number entered on a separate line with a return.

Anyway, the code works for me after I get rid of all the compile warnings/errors. How about posting the current, compilable (with no warnings) code?

Well I'm glad it works for you, its pretty odd I must admit. But like I said, I'm a newbie and to be honest I'm mostly figuring this out as I go, I use DEV C++ to write and compile and don't know what you mean about posting the compilable. From what I see there are no compiling errors or anything like that. And yes, I was entering the inputs on one line, if I try enter each input on different lines the program just keeps going back to "Enter the numbers you want to average"

jubjubj... are you working with any kind of tutorials or textbooks?

Also DEV C++ has been abandoned for several years now... You may want to update to something newer...
something like Pelles C for plain C... Code::Blocks with MinGW for C/C++...

Try the latest edition of "The C Programming Language" by Brian W. Kernighan and Dennis M. Ritchie.

C for Dummies 2nd edition

NO!

Teach Yourself C in 21 Days -- Table of Contents

Better than "C for Dummies", but still, no.

Also, as a matter of interest, I highly doubt that that site has Pearson's (the latest publishers) blessing.

Soma

NO!

FML already started reading it. :S

Originally Posted by MK27

I have never looked at "C for Dummies", but I did have "Programming for Dummies" out from the library for a long time. I thought it was a pretty decent reference, actually -- in fact, I've never seen a more succinct and useful description of sort algorithms (bucket, bubble, merge, quick, heap, etc.) anywhere. There was virtually no long winded tripe and great use of pseudo code and flow diagrams. Way better than 80% of online tutorials/blogs.

A lot of people seem to enjoy learning with the K&R book phantomotap recommends tho. People will show up here with the exercises, etc, and they (K&R) are the dudes who wrote the language in the first place, so they probably have some insight.

Thanks for the reassurance! I might just read both, because I'm really enjoying C for dummies, its humorous attitude keep's me engaged, as I'm not a huge fan of books. But I'll be sure to read the K&R one too since it is

"regarded by many to be the authoritative reference on C"

- Wikipedia.