Thread: Load file from disk to memory

I'm trying to program very simple web server and I'm stuck on how to fill buffer with file content.
Here's the code:

Code:

#include <stdio.h>
#include <stdlib.h>

int main(){
    
    char * buffer = malloc(512);
    
    FILE *fp;
    fp = fopen("./index","r");
    char chr;
    char *reset;
    printf("Buffer address: %x\n", buffer);
    
    reset = buffer;
    
    while( (chr = getc(fp)) != EOF){
        *buffer = chr;
        buffer++;
        printf("%c", *buffer); 
    }
    
    printf("*Buffer address after fill: %x\n", buffer);

    buffer = reset;
    
    printf("*Buffer address after reset: %x\n", buffer);
    
    /* print content of buffer */
    while(*buffer != EOF){
        printf("%c", *buffer);
        buffer++;
    }
       
    
    return 0;
}

So I get trash on the output. Looks like nothing has been stored in buffer...
Maybe I'm doing it completely wrong.

EOF is never stored in your buffer; so I don't see how your last while loop will stop.

It is better to read blocks of data from a file. You will be VERY slow if you read large files one byte at a time. Look up read(). Also, why buffer the whole file if you plan to just print it to stdout? Just dump each block to stdout as you read() [just be sure to add a '\0' to the end of your buffer].

Originally Posted by Kennedy

It is better to read blocks of data from a file. You will be VERY slow if you read large files one byte at a time. Look up read(). Also, why buffer the whole file if you plan to just print it to stdout? Just dump each block to stdout as you read() [just be sure to add a '\0' to the end of your buffer].

Yeah, you're right...too many reads and writes.
I'm currently using stdout as a test, but it will be replaced with socket file descriptor later in child process.
I'll rewrite the code and see if works.

Thank you.