can somebody tell me what is wrong here? tnQ
Code:#include <stdio.h> #include <conio.h> int main(void) { int n; int niz[n]; scanf("%d", &n); for(int i = 0; i < n; i++) scanf("%d", &niz[i]); for(int i = 0; i <n; i++) { int j = i + 1,k; if(niz[i] > niz[j]) { k = niz[j]; niz[j] = niz[i]; niz[i] = k; } } for(int i = 0; i < n; i++) printf("%d", niz[i]); getch(); return 0; }
int niz[n]Originally Posted by broken_heart
You haven't given the size of the array niz. It must be hard-coded to some maximum number, or you have to allocate memory for it once you've determined how many elements you need.
so I just have to switch places of int niz[n] with scanf("%d", &n)Thanx and btw I have one more mistake which I've noticed moment ago sry.. this is remodeled code:
tnQ you for respondCode:#include <stdio.h> #include <conio.h> int main(void) { int n; scanf("%d", &n); int niz[n]; for(int i = 0; i < n; i++) scanf("%d", &niz[i]); for(int i = 0; i <n; i++) { for(int j = i+1; j < n; j++) { int k; if(niz[i] > niz[j]) { k = niz[j]; niz[j] = niz[i]; niz[i] = k; } } } for(int i = 0; i < n; i++) printf("%d\t", niz[i]); getch(); return 0; }
Last edited by broken_heart; 09-18-2009 at 03:52 PM.
No it won't work. int niz[n] is is not legal no matter where it's placed.
Except, of course, it is. (Look up: C Programming, not C++ Programming.)
Declaring arrays with variable sizes (Variable Length Arrays) is part of the latest C standard, C99, as tabstop has indicated. But it's not part of the C89 standard, which most compilers still use (especially compilers which support getch()).
I would suggest using dynamic memory allocation here. That's what it's for. For example:
Regarding getch(): it's nonstandard and unportable. Don't use it, click here instead.Code:#include <stdio.h> /* for scanf(), etc. */ #include <stdlib.h> /* for malloc() and free() */ int main() { int n; int *array; printf("How big do you want the array to be? "); scanf("%d", &n); array = malloc(sizeof(*array) * n); /* ... use array ... */ free(array); return 0; }
dwk
Seek and ye shall find. quaere et invenies.
"Simplicity does not precede complexity, but follows it." -- Alan Perlis
"Testing can only prove the presence of bugs, not their absence." -- Edsger Dijkstra
"The only real mistake is the one from which we learn nothing." -- John Powell
Other boards: DaniWeb, TPS
Unofficial Wiki FAQ: cpwiki.sf.net
My website: http://dwks.theprogrammingsite.com/
Projects: codeform, xuni, atlantis, nort, etc.
Don't know if I'd go that far, since getch could come from curses. More apt to say "compilers which use conio.h", I would guess.
You know what I mean.
A suggestion to the OP: work on your indentation. If you write more than a few tens of lines with that sort of indentation, all you'll accomplish is to confuse yourself.
dwk
Seek and ye shall find. quaere et invenies.
"Simplicity does not precede complexity, but follows it." -- Alan Perlis
"Testing can only prove the presence of bugs, not their absence." -- Edsger Dijkstra
"The only real mistake is the one from which we learn nothing." -- John Powell
Other boards: DaniWeb, TPS
Unofficial Wiki FAQ: cpwiki.sf.net
My website: http://dwks.theprogrammingsite.com/
Projects: codeform, xuni, atlantis, nort, etc.
Variable length arrays are still stack-based and I didn't think they worked when they are attempted in main as in the example given. Only in functions.
I could be wrong there too - as I completely forgot about variable-length-arrays. 1/2 point towards tabstop, voided by minus 1/2 point for his sarcasm.
is it necessary to use free() function?
Code:free(array);
Nope.
Yay! Not negative!
