fprintf file problem

[ch4]

Check this code

#include <stdio.h>
#include <string.h>
#include <stdlib.h>
#include <ctype.h>

int main(void) 
{
 int length=strlen("<tilefono>")+1;
 int i=0;

 char *tag;
 char ch;

 FILE *xmlIN;
 FILE *xmlOUT;

     tag=(char *)malloc(length*sizeof(char));
     if(tag==NULL)
     {
      fprintf(stderr,"Allocation Error\n");
      exit(-1);
     }

     xmlIN = fopen("A.xml","rb");
     if(xmlIN==NULL)
     {
      fprintf(stderr,"Cannot open &#37;s\n","A.xml");
      exit(-2); 
     }

     xmlOUT = fopen("B.xml","wb");
     if(xmlIN==NULL)
     {
      fprintf(stderr,"Cannot open %s\n","B.xml");
      exit(-2); 
     }

     while(ch!=EOF)
     {
      i=0;
      ch=getc(xmlIN);

      if(ch!=EOF)
         putc(ch,xmlOUT);

      if(ch=='<')
      {
        tag[i++]=ch;
        while(ch!='>')
        {
          ch=getc(xmlIN);
          putc(ch,xmlOUT);
          tag[i++]=ch;

          if((ch==EOF)||(i>=length-1))
             break;
        }

        if(strcmp(tag,"<tilefono>")==0)
        {
          ch=getc(xmlIN);
          while(!isdigit(ch))
          {
            putc(ch,xmlOUT);
            ch=getc(xmlIN);
          }
          fprintf(xmlOUT,"0030");
          putc(ch,xmlOUT);
        }
      }
     }

     fclose(xmlIN);
     fclose(xmlOUT);
     free(tag);

     printf("\n\t\t\tJob Done !\n");


 return 0;
}

The above code add the 0030 prefix between <tilefono> tag from A.xml and the result is B.xml which is a copy of A including the 0030 prefix after<tilefono> tag.

I tried the code on Windows Xp / Linux and worked fine.
But i tried it on an another pc (Windows Xp) and fprintf didn't work. Every element copied exept the string 0030.

ex.
A.xml

<?xml version='1.0'?>
<!-- askhsh 2 -->
<name>
<tilefono>
2104112345
</tilefono>
</name>

B.xml (worked fine on Xp/Linux)

<?xml version='1.0'?>
<!-- askhsh 2 -->
<name>
<tilefono>
00302104112345
</tilefono>
</name>

B.xml (fprintf problem on another pc using XP) No prefix !!!

<?xml version='1.0'?>
<!-- askhsh 2 -->
<name>
<tilefono>
2104112345
</tilefono>
</name>

Is there any chance to happen this fault ????
Did i do something wrong ??

[stevesmithx]

I get the expected output.
What compiler are you using?
Edit:
I am using Mingw port of GCC in Windows XP.

[ch4]

I get the expected output.
What compiler are you using?
Edit:
I am using Mingw port of GCC in Windows XP.

I used in the first pc DevC++4.9.9.2 on Xp and Gcc on Linux(third pc) but the second pc(WinXP) had not the expected output.

In reality i have no problem with that but i need an explanation. (The other pc is not mine)

[ch4]

I suppose the fault belongs to the OS of the 2nd pc (WinXP).

[dwks]

        tag[i++]=ch;
        while(ch!='>')
        {
          ch=getc(xmlIN);
          putc(ch,xmlOUT);
          tag[i++]=ch;

          if((ch==EOF)||(i>=length-1))
             break;
        }

        if(strcmp(tag,"<tilefono>")==0)

You don't NULL-terminate tag, so strcmp() probably won't do what you expect. Oh, and if you reach the end of the file in that while loop, you'll print an EOF character to the output file, which should probably be avoided.

[ch4]

Thanks i haven't noticed that.

[ch4]

I found the problem. (in red)

#include <stdio.h>
#include <string.h>
#include <stdlib.h>
#include <ctype.h>

int main(void) 
{
 int length=strlen("<tilefono>")+1;
 int i=0;

 char *tag;
 char ch;

 FILE *xmlIN;
 FILE *xmlOUT;

     tag=(char *)malloc(length*sizeof(char));
     if(tag==NULL)
     {
      fprintf(stderr,"Allocation Error\n");
      exit(-1);
     }

     xmlIN = fopen("A.xml","rb");
     if(xmlIN==NULL)
     {
      fprintf(stderr,"Cannot open %s\n","A.xml");
      exit(-2); 
     }

     xmlOUT = fopen("B.xml","wb");
     if(xmlIN==NULL)
     {
      fprintf(stderr,"Cannot open %s\n","B.xml");
      exit(-2); 
     }

     while(ch!=EOF)
     {
      i=0;
      ch=getc(xmlIN);

      if(ch!=EOF)
         putc(ch,xmlOUT);

      if(ch=='<')
      {
        tag[i++]=ch;
        while(ch!='>')
        {
          ch=getc(xmlIN);

          if(ch==EOF)
             break;  

          putc(ch,xmlOUT);
          tag[i++]=ch;
          
          if(i>=length-1)
             break;
        }
        tag[i]='\0';

        if(strcmp(tag,"<tilefono>\0")==0)
        {
          ch=getc(xmlIN);
          while(!isdigit(ch))
          {
            putc(ch,xmlOUT);
            ch=getc(xmlIN);
          }
          fprintf(xmlOUT,"0030");
          putc(ch,xmlOUT);
        }
      }
     }

     fclose(xmlIN);
     fclose(xmlOUT);
     free(tag);

     printf("\n\t\t\tJob Done !\n");

 return 0;
}