Thread: File i/o and ASCII question

Looks like Line 18 is about the difference in the type of the function arguments in the caller and the callee as well as in the prototype. Pass one instead of two levels of indirection in the callee and the prototype ie

Code:

bool openFiles(FILE *pFPIn, FILE *pFPOut, int *input1, int *input2);

IMHO though what's the need of passing all the arguments to openFiles() when you aren't even using them there. All the parameters can simply be local variables.

Line 35 looks like part of an if-else statement. Its missing the if keyword and a parenthesis as in.

Code:

if (fscanf(fpIn, "%d%d", &input1, &input2) == 2)

Originally Posted by itCbitC

Looks like Line 18 is about the difference in the type of the function arguments in the caller and the callee as well as in the prototype. Pass one instead of two levels of indirection in the callee and the prototype ie

Code:

bool openFiles(FILE *pFPIn, FILE *pFPOut, int *input1, int *input2);

IMHO though what's the need of passing all the arguments to openFiles() when you aren't even using them there. All the parameters can simply be local variables.

Well I can take out the last two args, but the first two have to be there

Code:

  bool openFiles(FILE **pFPIn, FILE **pFPOut);

my teacher requires that I use that prototype

Originally Posted by itCbitC

Line 35 looks like part of an if-else statement. Its missing the if keyword and a parenthesis as in.

Code:

if (fscanf(fpIn, "%d%d", &input1, &input2) == 2)

Thanks. Since it's not supposed to be an if-else statement I removed the end and it works properly now

Code:

 fscanf(fpIn, "%d%d", &input1, &input2);

So it is required of you to use two levels of indirection where one suffices??

Originally Posted by itCbitC

So it is required of you to use two levels of indirection where one suffices??

If you want to change the value of the pointer passed in (say, by opening a file, which seems silly in a function called openFiles, but there you go) you would need to pass a pointer to the pointer.

Originally Posted by tabstop

If you want to change the value of the pointer passed in (say, by opening a file, which seems silly in a function called openFiles, but there you go) you would need to pass a pointer to the pointer.

Your point is correct, however openFiles() isn't using or changing them in any way as it's using two local FILE * pointers.

Originally Posted by itCbitC

Your point is correct, however openFiles() isn't using or changing them in any way as it's using two local FILE * pointers.

Which is the problem.

Originally Posted by itCbitC

So it is required of you to use two levels of indirection where one suffices??

Are you saying that one suffices in my function, or in general? If it's the former, than my function will need to be changed. (or my teacher made a typo) :|