letter to upper

hi im trying to make it when the player types a letter it will be uppercase...it compiles and runs but does not convert to uppercase... heres the code:

Code:

---

#include <iostream.h>
#include <ctype.h>
int main()
{
char letter;
cout<<"Enter a letter : ";
cin>>letter;
letter=toupper(letter);
std::cin.ignore();
return 0;
}

---

hmm... why dont you print the letter and have a look?

Ok, I think I see what you mean. But run this:

Code:

---

#include <iostream.h>
#include <ctype.h>


int main()
{
        char letter;
        cout<<"Enter a letter : ";
        cin>>letter;

        letter=toupper(letter);

        cout<< letter;

        return 0;
}

---

I think what you want is this:

Code:

---

#include <iostream.h>
#include <conio.h>
#include <ctype.h>


int main()
{
        char letter;
        cout<<"Enter a letter : ";
        letter = getch();                // The user doesn't have to press enter

        letter=toupper(letter);       

        cout<< letter;

        return 0;
}

---

Conio.h is not standard, so this may/maynot work, it does for me tho ;)

Also, you can do this on a loop easily enough. Just make a string, and in a loop say StringName[i] += letter. You'll have to do something about backspaces I think, so the best way to do this is to read in a whole string at once, and then get a loop to 'toupper' it, if you get me.

doesnt work

the first code printed the letter in lower case and the second code closed it when i press a letter

Quote:

---

Originally Posted by k1ll3r

doesnt work

---

What doesn't?

Quote:

---

doesnt work

---

How does it not work? Also what exactly do you want to do? twomers caught on that you might have something else in mind, one that will need something non-standard like conio.

the first code printed the letter in lower case and the second code closed it when i press a letter

Put in your

std::cin.ignore();

then

Quote:

---

How does it not work? Also what exactly do you want to do?

---

i just want the letter/s i type to appear in capital letter

Quote:

---

the first code printed the letter in lower case

---

That should not happen.

Quote:

---

the second code closed it when i press a letter

---

Run the program from the command line, or add something like std::cin.ignore... have you tried a hello world program yet?

do this so:

Code:

---

#include <iostream>
#include <string>

using namespace std;


int main()
{
        string MyString;

        cout<<"Enter a string of letters( no spaces!!): ";
        cin >> MyString;

        for ( int i=0; i<MyString.length(); i++ )       
        {
                MyString[i] = toupper( MyString[i] );
        }

        cout<< MyString;

        return 0;
}

---

and put that ignore thing there if you want

Quote:

---

Run the program from the command line, or add something like std::cin.ignore... have you tried a hello world program yet?

---

i did try std::cin.ignore(); and i have tried a hello program :)
Adding std::cin.ignore(); just makes the first letter i type invisible and then the next letters in lowercase.

do this so:

Code:

---

Code:
#include <iostream>
#include <string>

using namespace std;


int main()
{
        string MyString;

        cout<<"Enter a letter : ";
        cin >> MyString;

        for ( int i=0; i<MyString.length(); i++ )       
        {
                MyString[i] = toupper( MyString[i] );
        }

        cout<< MyString;

        return 0;
}

---

that once again is in lowercase

Not when I run it

maybe it has something to do with the compilers?i have no clue
btw:im using dev tool c++

I don't think it should ... I'm using MSVC++ ... someone else, probably wiser, will know.

thank for the help ne way

Just to confirm: you did press the enter key, right?

Quote:

---

Originally Posted by laserlight

Just to confirm: you did press the enter key, right?

---

:p

But, it should work!! There's nothing wrong with it. I've tried it again and again. Did you compile, build and do everythink to it. Maybe it's not happy with the linking. I don't know

>>the first code printed the letter in lower case

no - it shows whatever you entered on whatever case you
entered and prints it in upper case on a newline (as a result of
pressing enter)

>>second code closed it when i press a letter
FAQ

>>Put in your std::cin.ignore(); then

I think he means a cin.get(); - which may need a cin.ignore();
before it as cin leaves newlines. He meant this in regard to the
console box disappearing

Restate your problem - do you want to type something and see
it converted to upper case, or do you want to type something
and see it on screen in upper case AS you type it?

[EDIT]
Read laserlights sig on how to ask a question!
[/EDIT]

>> [EDIT]
Read laserlights sig on how to ask a question!
[/EDIT]

forgot the good before 'a' and 'question' richie!

Try this:

Code:

---

#include <iostream>
#include <string>

using namespace std;
void main()
{

        string inputstring;
       
        cin >> inputstring ;
        string myString(inputstring);
        strupr((char *) myString.c_str());
       
        cout<< myString.c_str();

}

---

Shal, hope you realise:

1. void main() should be int main()
2. strupr() is non-standard
3. Using c_str() the way you did is asking for trouble. c_str() returns a const char*, and you really shouldnt be casting away the const-ness like that, and then try to change what should not be changed in that way.

This is a complete input fetching routine for you, which should do what you want. You will only see capital letters regardless of what the user types and everything is put into a string.

I also use Dev C++ so it really shouldn't be a portability problem for you.

Code:

---

#include <iostream>
#include <conio.h>
#include <cctype>
#include <string>

int main()
{
  std::string mystring;
  char letter;
  std::cout<<"Enter string: ";
  while((letter = getch()) != EOF && letter != '\n' && letter != '\r')
      if(letter == '\b' && mystring.size() > 0) {
          std::cout<<"\b \b";
          mystring.erase(mystring.size()-1);
      }
      else if(std::isalnum(letter) || std::isspace(letter) || std::ispunct(letter)) {
          letter = std::toupper(letter);
          std::cout << letter;
          mystring.append(1, letter);
      }
 
  std::cout<< "\nYou entered [" << mystring << "]\n";
  std::cin.get();

  return 0;
}

---

Ya, I know its a bit cryptic to do it this way, but as k1ll3r could not compile the previous code so I thot of trying some different way.

but I surely agree to ur point 2 n 3.

but I am not convinced when it comes to main!!
main should return int as per ANSI/ISO standard. But making it void also won't make any difference. The return value would be helpful if I want my start up code to check if main executed successfully or not. Otherwise any ways its gonna be return "0".

I just do int main() out of habbit, but there is no reason why the code I posted shouldn't have worked I think!

void main results in any old junk being returned to the OS - which
I assume could (possibly) lead it to believe that your program
crashed - not a big problem for small programs but I imagine that
larger programs that are more resource dependant it could cause
issues.

We still haven't heard from the OP since my lasy post... perhaps
some feedback from him/her will result in a resolution to this.

wow i didnt expect to see that many replys thanks all--now back to the subject, citizens code worked but its kinda long and hard to understand could it be umm simplified?

Quote:

---

citizens code worked but its kinda long and hard to understand could it be umm simplified?

---

Not by much, though there are a few places where say, empty() should be used instead of checking size().

Here is a commented version of the program, with a few minor modifications:

Code:

---

#include <iostream>
#include <cctype>
#include <string>
#include <conio.h> // for the non-standard getch() function

int main()
{
        std::string mystring; // string entered by user, with backspaces accounted for
        char letter;          // current character entered by user

        std::cout << "Enter string: ";

        // grab the string character by character
        // getch() reads in the character without having it printed to screen
        // terminate when EOF or a newline/carriage return is encountered
        while ((letter = getch()) != EOF && letter != '\n' && letter != '\r') {
                // handle backspaces by removing the most recent character
                // check that the string is not empty, to avoid removing from an empty string
                if (letter == '\b' && !mystring.empty()) {
                        // remove printed character from screen
                        std::cout << "\b \b";
                        // remove from string
                        mystring.erase(mystring.size() - 1);
                }
                // handle printable characters
                else if (std::isprint(letter)) {
                        // change character to uppercase, if applicable
                        letter = std::toupper(letter);
                        // print character to screen
                        std::cout << letter;
                        // append character to string
                        mystring.push_back(letter);
                }
        }

        // print string
        std::cout<< "\nYou entered [" << mystring << "]\n";
        std::cin.get();
        return 0;
}

---

thanks laserlight!

I'm sorry that other version was so incredibly complicated. I wasn't really sure what kind of character you wanted the routine to accept, so I had to be explicit with std::isalnum and stuff so you could modify it with better understanding. That size thing was just my fault... I forgot about empty! :o