letter to upper

hi im trying to make it when the player types a letter it will be uppercase...it compiles and runs but does not convert to uppercase... heres the code:

Code:

#include <iostream.h>
#include <ctype.h>
int main()
{
char letter;
cout<<"Enter a letter : ";
cin>>letter;
letter=toupper(letter);
std::cin.ignore();
return 0;
}

hmm... why dont you print the letter and have a look?

Ok, I think I see what you mean. But run this:

Code:

#include <iostream.h>
#include <ctype.h>


int main()
{
	char letter;
	cout<<"Enter a letter : ";
	cin>>letter;

	letter=toupper(letter);

	cout<< letter;

	return 0;
}

I think what you want is this:

Code:

#include <iostream.h>
#include <conio.h>
#include <ctype.h>


int main()
{
	char letter;
	cout<<"Enter a letter : ";
	letter = getch();		// The user doesn't have to press enter

	letter=toupper(letter);	

	cout<< letter;

	return 0;
}

Conio.h is not standard, so this may/maynot work, it does for me tho

Also, you can do this on a loop easily enough. Just make a string, and in a loop say StringName[i] += letter. You'll have to do something about backspaces I think, so the best way to do this is to read in a whole string at once, and then get a loop to 'toupper' it, if you get me.

doesnt work

the first code printed the letter in lower case and the second code closed it when i press a letter

Originally Posted by k1ll3r

doesnt work

What doesn't?

doesnt work

How does it not work? Also what exactly do you want to do? twomers caught on that you might have something else in mind, one that will need something non-standard like conio.

the first code printed the letter in lower case and the second code closed it when i press a letter

Put in your

std::cin.ignore();

then

How does it not work? Also what exactly do you want to do?

i just want the letter/s i type to appear in capital letter

the first code printed the letter in lower case

That should not happen.

the second code closed it when i press a letter

Run the program from the command line, or add something like std::cin.ignore... have you tried a hello world program yet?

do this so:

Code:

#include <iostream>
#include <string>

using namespace std;


int main()
{
	string MyString;

	cout<<"Enter a string of letters( no spaces!!): ";
	cin >> MyString;

	for ( int i=0; i<MyString.length(); i++ )	
	{
		MyString[i] = toupper( MyString[i] );
	}

	cout<< MyString;

	return 0;
}

and put that ignore thing there if you want

Run the program from the command line, or add something like std::cin.ignore... have you tried a hello world program yet?

i did try std::cin.ignore(); and i have tried a hello program
Adding std::cin.ignore(); just makes the first letter i type invisible and then the next letters in lowercase.

do this so:

Code:

Code:
#include <iostream>
#include <string>

using namespace std;


int main()
{
	string MyString;

	cout<<"Enter a letter : ";
	cin >> MyString;

	for ( int i=0; i<MyString.length(); i++ )	
	{
		MyString[i] = toupper( MyString[i] );
	}

	cout<< MyString;

	return 0;
}

that once again is in lowercase

Not when I run it

maybe it has something to do with the compilers?i have no clue
btw:im using dev tool c++