Condensing my code

[baseball07]

Hello, I would like to condense my code down but I am not sure how I can do it. I repeat the same lines of code (putchar commands), but modify whats in the the writespeech parentheses when I want to speak something different, so I was wondering if there was a way to call the commands each time I want to use it. The code I repeat is a serries of commands that I send to my text to speech module, with the text I want to speak right in the middle. Everytime I want to speak a different line of text I need to repeat these lines of command with different text inside. The text gets spoken after the 0x1A command is sent.

   putchar(0x80); //sp03 commands
   DelayMs(1);
   putchar(0x01);
   DelayMs(1);
   putchar(0x05);
   DelayMs(1);
   putchar(0x01);
   DelayMs(1);

   //sends text to speech module
   Writespeech("Welcome to the accessible home vital signs monitor");
   DelayMs(1);

   putchar(0x1A);  //speaks it after 0x1A is sent
   DelayMs(1);
   putchar(0x00);

If the line to be spoken wasn't smack in the middle, I could declare it as a function and call the function when I needed to send the commands. How can I change this so I don't have to keep repeating the commands everytime I want to speak my text?

[KONI]

How about this:

void saySomething(char text[])
{
putchar(0x80);	//sp03 commands
DelayMs(1);
putchar(0x01);
DelayMs(1);
putchar(0x05);
DelayMs(1);
putchar(0x01);
DelayMs(1);
			
Writespeech(text);  //sends text to speech module
DelayMs(1);

putchar(0x1A);  //speaks it after 0x1A is sent
DelayMs(1);
putchar(0x00);
}

[baseball07]

Ok thanks KONI. So basically when I want to call this function, I willl have to forst put it into an array using sprintf, then call the function?? Like this??

sprintf(saySomething, "Hello world");
saySomething(char text[15])

I am new to C, is this the correct approach?

[dwks]

Sort of. The idea is right, the code isn't. There are many ways to store data into a buffer -- and if the data is just a plain string, you don't even need a buffer:

void function(char buffer[]);

char buffer[15];
sprintf(buffer, "This is number %d", 5);
function(buffer);

strcpy(buffer, "Hello, World!");
function(buffer);

function("Goodbye, world!");

[baseball07]

Thank you, I am getting errors though in my compiler (Hi-Tech PICC). My code is the following format:

void saysomething(char text[25])
{
putchar(0x80);	//sp03 commands
DelayMs(1);
putchar(0x01);
DelayMs(1);
putchar(0x05);
DelayMs(1);
putchar(0x01);
DelayMs(1);
			
Writespeech(text);  //sends text to speech module
DelayMs(1);

putchar(0x1A);  //speaks it after 0x1A is sent
DelayMs(1);
putchar(0x00);
}

main()
{
char text[25];

	strcpy(text, "Hello World");
	saysomething(text);
}

I get the error that my signatures don't match. Am I not declaring something correct? I also tried removing the 25 from the array up top in the void function.

[whiteflags]

Make sure that the necessary libraries, including: <stdio.h> and <string.h> are included
and that you return 0 from int main.

Also double check the spelling of DelayMs and Writespeech: if you're calling them incorrectly (by typing in another case, for example) you'll get compile-time errors. Other than that, I have no idea why you're signatures don't match yet. They look like they do.

[ssharish2005]

Make sure that you have included the appropraite library's for your DelayMs and whitespeech function.

ssharish2005

[Adak]

Hello, I would like to condense my code down but I am not sure how I can do it. I repeat the same lines of code (putchar commands), but modify whats in the the writespeech parentheses when I want to speak something different, so I was wondering if there was a way to call the commands each time I want to use it. The code I repeat is a serries of commands that I send to my text to speech module, with the text I want to speak right in the middle. Everytime I want to speak a different line of text I need to repeat these lines of command with different text inside. The text gets spoken after the 0x1A command is sent.

   putchar(0x80); //sp03 commands
   DelayMs(1);
   putchar(0x01);
   DelayMs(1);
   putchar(0x05);
   DelayMs(1);
   putchar(0x01);
   DelayMs(1);

   //sends text to speech module
   Writespeech("Welcome to the accessible home vital signs monitor");
   DelayMs(1);

   putchar(0x1A);  //speaks it after 0x1A is sent
   DelayMs(1);
   putchar(0x00);

(half code really)

Speak(int n, int i, *pointer to the right array index of char pointers)  {
  
  for (i = 0; i < 5; i++)  {
     char ch = char Array[i]
     putchar(ch)
     DelayMS(n)

     if (i == 4) {
        WriteSpeech(pointer to array of char pointers to text messages)
         DelayMS(n) 
     }
  } /* end of for */
  putchar(i)  /* the final putchar has no matching delayMS() */
} /* end of function */

A little log should help with setting up the right messages:
===========
1 - Welcome
2 - Inquiry
3- Calling for help
etc.,
where #1 is the pointer to the welcome string of char's

Adak

[baseball07]

ahhhh i didnt have <string.h>, thanks!!