Thread: Password Problem

So, you have two uninitialized char variables (guess and password). You then assign guess to password, and check if it's non-zero, and set the caption to "ok".

This all seems wrong to me.

First of all, shouldn't password and guess be something that comes from the outside (e.g. parts of the form)? And I'm almost certain they should be strings rather than single chars...

And you should COMPARE the guess with password, rather than assign it...

--
Mats

Code:

#include <string.h>

void __fastcall TForm1::Button1Click(TObject *Sender)
{

 char Password[256]; //need enough char's to fit the password + 1
 char guess[256];


//now fill the Password from the source / database / ect

//get the users input into 'guess'
//from the Password edit on Form1 

//compare char arrays ( == will not work )
if( strcmp ( guess, Password) == 0) //are same
{
          lbOutput->Caption = "ok";
}

Shouldn't this

if ( edPassword == "administrator")//you are using the EDIT control


be

if ( password == "administrator")//should be using the char array (text)




but you can not (usually) do a string compare without using a class (CString or string)

try

if ( strcmp(password, "administrator") == 0 )//match, include <string.h>