GlobalAlloc

[rwmarsh]

I am going through the tutorial on TheForgers and I am at the part that talks about using files. I am having problems getting the GlobalAlloc function to work. Here is what I have :

BOOL LoadTextFileToEdit(HWND hEdit, LPCTSTR pszFileName)
{
	HANDLE hFile;
	BOOL bSuccess = FALSE;

	hFile = CreateFile(pszFileName, GENERIC_READ, FILE_SHARE_READ, NULL,
		OPEN_EXISTING, 0, NULL);
	if(hFile != INVALID_HANDLE_VALUE)
	{
		DWORD dwFileSize;

		dwFileSize = GetFileSize(hFile, NULL);
		if(dwFileSize != 0xFFFFFFFF)
		{
			LPSTR pszFileText;

			pszFileText = GlobalAlloc(GPTR, dwFileSize + 1);
			if(pszFileText != NULL)
			{
				DWORD dwRead;

				if(ReadFile(hFile, pszFileText, dwFileSize, &dwRead, NULL))
				{
					pszFileText[dwFileSize] = 0; // Add null terminator
					if(SetWindowText(hEdit, pszFileText))
						bSuccess = TRUE; // It worked!
				}
				GlobalFree(pszFileText);
			}
		}
		CloseHandle(hFile);
	}
	return bSuccess;
}

and the compiler is telling me : invalid conversion from "void*' to `CHAR*" for the hilighted line. Just a little confused as everything I have read indicates that this should work, But it dosn't.....
Any help is appreciated

[Dave_Sinkula]

Compile it as C. If you compile it as C++, you will need to add the cast.

pszFileText = (LPSTR)GlobalAlloc(GPTR, dwFileSize + 1);

[Salem]

Why are you using it?
http://msdn.microsoft.com/msdnmag/issues/0700/hood/
"GlobalAlloc still exists in Win32, but only to ease porting of Win16 code"

[rwmarsh]

Well, I think I figured it out..... i changed

pszFileText = GlobalAlloc(GPTR, dwFileSize + 1);

to

pszFileText = (LPSTR)GlobalAlloc(GPTR, dwFileSize + 1);

and it worked just fine... I do not know if this is the best way to do this(????) but it is working now....

[rwmarsh]

Why are you using it?

Like I said, that is how it is done in the tutorial I am reading, And as I am just learning windows API and I do not know of any other way to do it.......

[Dante Shamest]

You might want to take a look at the HeapAlloc and HeapFree functions.

The standard malloc and free functions can also be used.

[Salem]

Perhaps you should consider the possibility that it's an old tutorial?
There's plenty of TurboC tutorials still about, but that doesn't make them any good.

[novacain]

>>Compile it as C. If you compile it as C++, you will need to add the cast

You can force the compiler to compile as C by changing the file extension from .cpp to .c (.h are for both)