Thread: enumerating process

Hi, I have this function that iterates through all the process and prints them:

Code:

int ProcessJudger (void){
  
  // enumerazione processi
  char szProcessName[MAX_PATH];
  DWORD aProcesses[1024], cbNeeded, cProcesses;
  unsigned int i;
  double tmp;
  
  // process identification number
  char tempid[MAX_PATH];
  char pid[MAX_PATH];
  int  PidNumber = 0;
  
  if ( !EnumProcesses( aProcesses,
                       sizeof(aProcesses),
                       &cbNeeded ) )
        return -1;

    cProcesses = cbNeeded / sizeof(DWORD);
    
    for ( i = 0; i < cProcesses; i++ ) {
      HANDLE hProcess = OpenProcess( PROCESS_QUERY_INFORMATION |
                                     PROCESS_VM_READ,
                                     FALSE,
                                     aProcesses[i] );
      if ( NULL != hProcess ) {
          HMODULE hMod;
          DWORD cbNeeded;

          if ( EnumProcessModules( hProcess,
                                   &hMod,
                                   sizeof(hMod),
                                   &cbNeeded 
                                 ) )
          {
              GetModuleBaseName( hProcess,
                                 hMod,
                                 szProcessName,
                                 sizeof(szProcessName));
          }// end nested IF
       }// end IF
       
       printf ("Processo: %s\n", szProcessName);
       

      CloseHandle( hProcess );
    }// end FOR
    
    printf("\n");
    
    return 0;
}

It seems to be working but it lists 3 times the same process, for example:

Processo: calc.exe
Processo: calc.exe
Processo: smss.exe
Processo: smss.exe
Processo: winlogon.exe
Processo: services.exe
Processo: lsass.exe
Processo: svchost.exe
Processo: svchost.exe
Processo: svchost.exe
Processo: svchost.exe
Processo: spoolsv.exe
Processo: Explorer.EXE
Processo: Explorer.EXE
Processo: AVGUARD.EXE
Processo: AVWUPSRV.EXE
Processo: nvsvc32.exe
Processo: SMAgent.exe
Processo: svchost.exe
Processo: svchost.exe
Processo: vsmon.exe
Processo: StartupMonitor.exe
Processo: zlclient.exe
Processo: AVGNT.EXE
Processo: boincmgr.exe
Processo: boinc.exe
Processo: setiathome_4.18_windows_intelx86.exe
Processo: msnmsgr.exe
Processo: WISPTIS.EXE
Processo: DevCpp.exe
Processo: msimn.exe
Processo: iexplore.exe
Processo: cmd.exe
Processo: Limiter.exe
Processo: calc.exe

any idea WHY it sees "calc.exe" (that is the last opened process) 3 times?

Probably because there are 3 instances

he no! because with the task manager and other tools I see just ONE instance.. and the also the first 2 "calc.exe" have 0 as pid, it is an error, but where?

and if I initialize szProcessName to "test", the first 2 processes will be "test"...strange!!

> printf ("Processo: %s\n", szProcessName);
Well you do print whatever happened to be in the buffer last, whether or not some previous functions returned 'success' or 'failure'.

thanx everyone I've put the printf into the :

Code:

if ( NULL != hProcess )

the strange thing is that I have to filter the first result, infact if I don't initialize

Code:

char szProcessName[MAX_PATH]

the first (bugged!) result is the last executed program.. if I initialize it to something, this something will be the first process found.. anyway I've filtered it out and it's working well, anyway I will debug better the code to see what it's really happening, because I'm afraid this will lead to some other nested bugs

thanks to everyone