Thread: Error using Dev-C++ in Windows

Originally Posted by Elysia

This error means you've done something illegal. The most common error is dereferencing an invalid pointer.
The snippet you shows does not demonstrate the problem.

Also, don't use magic numbers. A newline is '\n' or '\r' not 10.
I would also suggest you upgrade your IDE since it's no longer maintained AFAIK.
A list of IDEs: SourceForge.net: Integrated Development Environment - cpwiki

Thank you for the reply and the tip. I've only showed those snippets because the problem only started to occur once I started separating the code into different files. For confirmation, I will post the main code later.

Sadly, I do not understand your comment on "magic numbers". Yes, the number 13 used in the wait_loop() may seem arbitrary but that number is used because of the value it represents from getch(); it is the vale used for the <Enter> key.

Thank you for suggesting getting a new compiler, but I would rather not change compilers unless the compiler is the problem ( if it works, I'm happy with that )


Main file

Code:

#include "functions.h"

using namespace std;

struct room
{
    int xsize;
    int ysize;
    struct object
    {
        int xloc;
        int yloc;
    } obj[];
      
};

int main()
{
    struct room current = { 5 , 5 };
    current.obj[0].xloc = 1;
    current.obj[0].yloc = 1;
    current.obj[1].xloc = 3;
    current.obj[1].yloc = 4;
    cout << current.xsize << " " << current.ysize << "\n";
    cout << current.obj[0].xloc << " " << current.obj[1].xloc << "\n";
    wait_loop();
    current.obj[0].xloc++;
    cout << current.obj[0].xloc << "\n";
    wait_loop();
    return 1;   
}

My apologies for the lack of in-code comments.

Originally Posted by Elysia

This should not compile!
You have an undefined numbers of objs in room, which you cannot have. You must specify a size! You are trying to access objects that do not exist.

Magic numbers refers to arbitary numbers in your code that means little or nothing. What does "13" mean, for example? If you used '\r' instead, it would be clear. It doesn't matter that it came from getch, you can ALWAYS compare to chars.

Thank you for inadvertently assisting me through a long, drawn-out and needless set of comments to the answer of my problem. Perhaps you should compare my comment to an int as you would clearly understand it better and the unnecessary effort required to properly compare it would most likely be appreciated by you.

Furthermore, without any superior analytical processes your comment would've been completely unhelpful and argumentative in nature.


P.S. "Cry me a river, build me a bridge, do us all a favour and jump off of it."

Elysia
Helpfulness: 1/10
Attitude: ........ty, unbecoming, unhelpful
Additional notes: Easily upset for no apparent reason other than "newbies" making mistakes. . . . . . like what he/she probably made.
Also thinks of themselves as superior for no clearly defined reason.

Recommendation: Do not ask Elysia for assistance of any kind.

Further info on Magic Numbers
Magic number (programming) - Wikipedia, the free encyclopedia

It is one of what is now days being called an Anti-pattern or Code Smell.
Anti-pattern - Wikipedia, the free encyclopedia
Code smell - Wikipedia, the free encyclopedia

Tim S