eof isn't working

[geek@02]

// Fill Refunds list
    while(1){
        ifstream ifs;
        char filedat0[50]="\0"; // File data buffer
        char pzData[50]="\0"; // Refund data
        ifs.open("C:\\Samudracoldb\\Refunds.txt",ios::in);
        ifs.getline(filedat0,30,'\n'); // Skip the 1st empty line
        ifs.getline(filedat0,30,'\n'); // Get index
        strcat(pzData,filedat0); // Append file data
        strcat(pzData," "); // Put a space
        ifs.getline(filedat0,30,'\n'); // Get name
        strcat(pzData,filedat0);
        strcat(pzData," ");
        ifs.getline(filedat0,30,'\n'); // Get item
        strcat(pzData,filedat0);
        strcat(pzData," ");
        ifs.getline(filedat0,30,'\n'); // Pass item n
        ifs.getline(filedat0,30,'\n'); // Pass price
        ifs.getline(filedat0,30,'\n'); // Get total
        strcat(pzData,filedat0);
        strcat(pzData,"/=");
        ifs.getline(filedat0,30,'\n'); // Skip last empty line

        m_clistRefunds.AddString(pzData);
        
        if(ifs.eof()) //*
            break; // Break at file end
    }

Hi
eof() isn't working here. the while loop never breaks. whats the problem here please? thanx.

[Salem]

> char pzData[50]="\0"; // Refund data
Just how many fields of up to 30 characters do you expect to be able to add to this array of 50 chars?

Stop messing with small char arrays which you're not using in any safe manner, and start using std::string.

[geek@02]

i dont get buffer overflow errors (cos every feild contains less than 7 chars - except the name field). but eof() never returns true ?

[Salem]

Including the \0 and the 6 other characters you concatenate as well?

Also, why are you opening the file INSIDE the while loop?

Also, eof() only becomes true when an input fails.
> ifs.getline(filedat0,30,'\n'); // Skip last empty line
Assuming this reads the last line, it will leave the file pointer at the end of the file, but it will NOT make eof() true. For that, you would need ANOTHER getline() call, which would have to fail to read any input, before eof() would become true.

eof() is a STATE set by a past event, not a prediction for a future event.

[geek@02]

>why are you opening the file INSIDE the while loop?
sorry my mistake -- open() should be on outside the loop. thx.