Thread: Save vs Save As.... OPENFILENAME flags

Sometimes you don't need to Save As perhaps just wanna save to default/existing file..
My DoFileSave() function which saves data to a file looks as follows

Code:

// File save dialog
void DoFileSave(HWND hwnd)
{
	OPENFILENAME ofn;
	char szFileName[MAX_PATH] = "";

	ZeroMemory(&ofn, sizeof(ofn));

	ofn.lStructSize = sizeof(OPENFILENAME);
	ofn.hwndOwner = hwnd;
	ofn.lpstrFilter = "Binary Files (*.dat)\0*.dat\0All Files (*.*)\0*.*\0";
	ofn.lpstrFile = szFileName;
	ofn.nMaxFile = MAX_PATH;
	ofn.lpstrDefExt = "dat";
	ofn.Flags = OFN_EXPLORER | OFN_PATHMUSTEXIST | OFN_HIDEREADONLY | OFN_OVERWRITEPROMPT;

	if(GetSaveFileName(&ofn))
	{
		WriteToFile(hwnd);
	}
}

What do i change in Flag (or this function) to prevent Save Save dialog box.. I'm adding both Save As & Save on the menu but do not know how to handle Save...

Originally Posted by Elysia

The File Open/Save Dialog is for asking for a filename to save to.
If you already have it (eg Save instead of Save As), then you don't need to open the dialog in the first place.

I have Save As, but need to change it to Save...

Originally Posted by iMalc

You (csonx_p) didn't understand.
When you select File -> Save from a program, it only runs code to call GetSaveFileName if the file has never been saved and hence has no file name yet. Somewhat like this:

Code:

void 

DoFileSave()
{
    if (filename != "")
        WriteToDisk(filename);
    else
        DoFileSaveAs();
}

coOL! That if statement will help! thnx

Originally Posted by iMalc

You (csonx_p) didn't understand.
When you select File -> Save from a program, it only runs code to call GetSaveFileName if the file has never been saved and hence has no file name yet. Somewhat like this:

Code:

void DoFileSave()
{
    if (filename != "")
        WriteToDisk(filename);
    else
        DoFileSaveAs();
}

void DoFileSaveAs()
{
    filename = MyGetSaveFileName();
    WriteToDisk(filename);
}

Oh! flip, hang-on... filename is pointed by lpstrFile member of OPENFILENAME... So, by calling DoFileSaveAs() at least once, then lpstrFile is initialized... But now this means OPENFILENAME must be global to keep pointing on filename until i quit the program... So from my function ..

Code:

// File save dialog
void DoFileSaveAs(HWND hwnd)
{
	OPENFILENAME ofn;
	char szFileName[MAX_PATH] = "";

	ZeroMemory(&ofn, sizeof(ofn));

	ofn.lStructSize = sizeof(OPENFILENAME);
	ofn.hwndOwner = hwnd;
	ofn.lpstrFilter = "Binary Files (*.dat)\0*.dat\0All Files (*.*)\0*.*\0";
	ofn.lpstrFile = szFileName;
	ofn.nMaxFile = MAX_PATH;
	ofn.lpstrDefExt = "dat";
	ofn.Flags = OFN_EXPLORER | OFN_PATHMUSTEXIST | OFN_HIDEREADONLY | OFN_OVERWRITEPROMPT;

	if(GetSaveFileName(&ofn))
	{
		WriteToFile(hwnd, szFileName);
	}
}

... i must declare OPENFILENAME ofn; globally rather so that i may use/test for it's members in other functions... correct????

Originally Posted by matsp

I think iMalc's code was not meant to be take literally, but rather as pseudo code. You may find that it's better to pass a filename as an argument.

--
Mats

Yes but to have the previous state of szFileName (filename which was saved), i either have to return it from DoFileSaveAs() or declare't globally ... Anywayz, think am getting both of u's clearly... @Mats, looked at the Double Buffering issue?

Originally Posted by Elysia

Ehm, you might be right. I think I mixed it up with something else - since I have only seen Windows programming and C, but no confirmation of C++...

On that note... Is C++ = MFC and C = Win API? ... @Elysia, i code in pure C... I get your point on char's... i have in number of cases used _TCHAR instead which i think is c compatible cause it compiled....