can anyone look at this and tell me if they can see whats wrong?

well, im having this problem that is quite aggrivating. it deals with some coding that is for one of my games in c++ (obviously), dos program...not win32. ignore the variable names and see if the syntax is right, please. if anything can find anything wrong with the syntax, please let me know. thanks in advance.

Code:

---

nummoves++;
if (incroh==1 || inelvencity==1 || inelvenpalace==1 || inminoisland==1) {
    if ((nummoves%5==0) && lvl75mod==1) {
          charhp++;
          if (charhp>=charmaxhp) { charhp=charmaxhp; }
    }
    if ((nummoves%5==0) && lvl75mod==2) {
          charmp++;
          if (charmp>=charmaxmp) { charmp=charmaxmp; }
    }
    if ((nummoves%5==0) && lvl75mod==0) {
          charhp=charhp; charmp=charmp;
    }
}

---

The syntax seems fine, the brackets in these lines


if (charmp>=charmaxmp) { charmp=charmaxmp; }

serve no pourpouse though, just do

if (charmp>=charmaxmp) charmp=charmaxmp;

are you getting error messages, or is it a logic error inside the game?

Looks OK, although I'd probably code it like this:

Code:

---

nummoves++;
if( (incroh==1 || inelvencity==1 || inelvenpalace==1 || inminoisland==1) && nummoves%5==0 )
{
    if( lvl75mod == 1 )
        charhp = (++charhp > charmaxhp) ? charmaxhp : charhp;
    else if( lvl75mod == 2 )
        charmp = (++charmp > charmaxmp) ? charmaxmp : charmp;
}

---

The last "if" test you are doing, for lvl75mod==0, isn't needed. It doesn't change the values in the variables.

that is way more confuseing in my opinion.

yeah, its logic error. thanks for the suggestions though. im gonna keep dissecting the areas around it later today...not outof school yet:)

later, and thanks again