beginner function problems

Code:

---

#include <stdio.h>
#include <math.h>




int getScore();
char convertGrade();
void showGrade();


int main(void)
{
int numGrade;
char letterGrade;

 numGrade=getScore();
 convertGrade();
 lettergrade=convertGrade();
 showGrade();

return (0);

}

int getScore()
        {
       
        int numGrade;

        printf ("Please enter your numeric grade> ");
        scanf ("%d", &numGrade);
        return numGrade;

        }



char convertGrade(int numGrade)

        {
        char lettergrade;


        if  ((numGrade >= 90) && (numGrade <= 100))
        {        lettergrade = 'A';
                return lettergrade;
        }

        else if ((numGrade >=80) && (numGrade <=89))
        {        lettergrade = 'B';
                return lettergrade;
        }

        else if ((numGrade >=70) && (numGrade <=79))
        {        lettergrade = 'C';
                return lettergrade;
        }


        else if ((numGrade >=60) && (numGrade <=79))
        {       
                lettergrade = 'D';
                return lettergrade;
        }

        else if ((numGrade >=59) && (numGrade <=0))
        {       
                lettergrade = 'F';
                return lettergrade;
        }

        else if ((numGrade >=100) || (numGrade <=0))
        {        lettergrade = 'Z';
                return lettergrade;
        }

        }

void showGrade(int numGrade, char lettergrade);
{
if (lettergrade==Z)
        printf ("invalid grade");

}

---

I'm trying to get this program work. I need to have three functions

Code:

---

int getScore();
char convertGrade();
void showGrade();

---

I'm receiving bunch of error and i'd post it here, but I can't get to my server right now.

What i'm trying to accomplish is to convert numeric grades to Lettergrades.

I remember an error that i kept receiving. It says "Previous declarion of showGrade was here".

Can someone help me to figure out what is wrong with my code?

The prototype differs from the function...

Code:

---

prototype = void showGrade();
function = void showGrade(int numGrade, char lettergrade);

---

They should be the same, you're also including a ; on the end of the function declaration -- which is a no, no.

Code:

---

void showGrade(int numGrade, char lettergrade);
{
if (lettergrade==Z)
        printf ("invalid grade");

}

---

Also, try work on your indenting -- it doesn't matter what style you use, only that you're consistant.

k, thanks...

but How do i show converted grades by having that function?

something like this?

Code:

---

void showGrade();
{
if (lettergrade==Z)
        printf ("invalid grade");

else

printf ("Your score of %d is &lf grade", numGrade, lettergreade);

}

---

how do i get the lettergrade and numgrade value from above functions?

You're going to have to pass the data into the function. In other words, change the function prototype to reflect reality, rather than the other way around.

Code:

---

void showGrade();

---

Note the ; at the end? Remove it. You should only use them on function prototypes, not the actual definitions.
And I suggest you also try to indent your code as in the example at http://cpwiki.sf.net/Indentation
Good luck.

I think zacs7 meant for you to change the prototype to match the function declaration.
[edit]as opposed to changing the function declaration to match the prototype[/edit]

Yes, the function declarations and definitions must match, so see that they do.

Code:

---

#include <stdio.h>
#include <math.h>

int getScore();
char convertGrade();
void showGrade(int numGrade, char lettergrade);


int main(void)
{
int numGrade;
char letterGrade;

 numGrade=getScore();
 convertGrade();
 lettergrade=convertGrade();
 showGrade();

return (0);

}

int getScore()
{
int numGrade;

printf ("Please enter your numeric grade> ");
scanf ("%d", &numGrade);
return numGrade;

}



char convertGrade(int numGrade)

{
char lettergrade;


if  ((numGrade >= 90) && (numGrade <= 100))
{        lettergrade = 'A';
                return lettergrade;
}

else if ((numGrade >=80) && (numGrade <=89))
{       
lettergrade = 'B';
return lettergrade;
}

else if ((numGrade >=70) && (numGrade <=79))
{
lettergrade = 'C';
return lettergrade;       
}


else if ((numGrade >=60) && (numGrade <=79))
{               
lettergrade = 'D';
return lettergrade;
}

else if ((numGrade >=59) && (numGrade <=0))
{       
lettergrade = 'F';
return lettergrade;
}

else if ((numGrade >=100) || (numGrade <=0))
{       
lettergrade = 'Z';
return lettergrade;
}

}

void showGrade(int numGrade, char lettergrade)
{
if (lettergrade==Z)
    printf ("Your score of %d is invalid grade", numGrade);
else
    printf ("Your score of %d is &lf grade", numGrade, lettergrade);
}

---

so will this be working fine?
I practice C using my school server(using PuTTy). They are down. I won't be able to test it till tomorrow. Can someone tell me if there is a thing going to give me an error?
or can someone tell me how else i can check my code online or on windows?

1. you should work on your indentetion - choose some editor that will do it for you, for example VS can do it when pressing Alt+F8 on selected text

2. Here are some compilation errors:

Code:

---

#include <stdio.h>
#include <math.h>

int getScore();
char convertGrade();
void showGrade(int numGrade, char lettergrade);


int main(void)
{
        int numGrade;
        char letterGrade;

        numGrade=getScore();
        convertGrade();
        lettergrade=convertGrade();//Error        1        error C2065: 'lettergrade' : undeclared identifier

        showGrade(); //Error        2        error C2198: 'showGrade' : too few arguments for call       


        return (0);

}

int getScore()
{
        int numGrade;

        printf ("Please enter your numeric grade> ");
        scanf ("&#37;d", &numGrade);
        return numGrade;

}



char convertGrade(int numGrade)

{
        char lettergrade;


        if  ((numGrade >= 90) && (numGrade <= 100))
        {        lettergrade = 'A';
        return lettergrade;
        }

        else if ((numGrade >=80) && (numGrade <=89))
        {       
                lettergrade = 'B';
                return lettergrade;
        }

        else if ((numGrade >=70) && (numGrade <=79))
        {
                lettergrade = 'C';
                return lettergrade;       
        }


        else if ((numGrade >=60) && (numGrade <=79))
        {               
                lettergrade = 'D';
                return lettergrade;
        }

        else if ((numGrade >=59) && (numGrade <=0))
        {       
                lettergrade = 'F';
                return lettergrade;
        }

        else if ((numGrade >=100) || (numGrade <=0))
        {       
                lettergrade = 'Z';
                return lettergrade;
        }

}

void showGrade(int numGrade, char lettergrade)
{
        if (lettergrade==Z) //Error        3        error C2065: 'Z' : undeclared identifier

                printf ("Your score of %d is invalid grade", numGrade);
        else
                printf ("Your score of %d is &lf grade", numGrade, lettergrade);
}

---

how do i fix them?

Error 1 - fix the name of the variable to match (including case) to the declared one
Error 2 - pass correct argumants to the function
Error 3
look at the code

Code:

---

else if ((numGrade >=100) || (numGrade <=0))
        {       
                lettergrade = 'Z';
                return lettergrade;
        }

---

And try to figure out the difference

Also pay attantion to your format

Code:

---

"Your score of %d is &lf grade"

---

You do not have a %c for printing lettergrade in it

Code:

---

#include <stdio.h>
#include <math.h>

int getScore();
char convertGrade();
void showGrade(int numGrade, char lettergrade);


int main(void)
{
        int numGrade;
        char lettergrade;

        numGrade=getScore();
        convertGrade();
        lettergrade=convertGrade();
        showGrade(int numGrade, char lettergrade);



        return (0);

}

int getScore()
{
        int numGrade;

        printf ("Please enter your numeric grade> ");
        scanf ("%d", &numGrade);
        return numGrade;

}



char convertGrade(int numGrade)

{
        char lettergrade;


        if  ((numGrade >= 90) && (numGrade <= 100))
        {        lettergrade = 'A';
        return lettergrade;
        }

        else if ((numGrade >=80) && (numGrade <=89))
        {       
                lettergrade = 'B';
                return lettergrade;
        }

        else if ((numGrade >=70) && (numGrade <=79))
        {
                lettergrade = 'C';
                return lettergrade;       
        }


        else if ((numGrade >=60) && (numGrade <=79))
        {               
                lettergrade = 'D';
                return lettergrade;
        }

        else if ((numGrade <=59) && (numGrade >=0))
        {       
                lettergrade = 'F';
                return lettergrade;
        }

        else if ((numGrade >=100) || (numGrade <=0))
        {       
                lettergrade = 'Z';
                return lettergrade;
        }

}

void showGrade(int numGrade, char lettergrade)
{
        if (lettergrade==Z)

                printf ("Your score of %d is invalid grade", numGrade);
        else
                printf ("Your score of %d is %c grade", numGrade, lettergrade);
}

---

this should fix 1st, 3rd errors. not sure about 2nd. can you check or try to compile now?

Quote:

---

showGrade(int numGrade, char lettergrade);

---

this is declaration, not a call

call function:

Code:

---

showGrade(numGrade, lettergrade);

---

About 3rd error - you fixed format, but did nothing about Z variable. It should be 'Z' constant

also in your last

Code:

---

else if ((numGrade >=100) || (numGrade <=0))

---

you can jsut drop the if part leavin it as

Code:

---

else
{       
        lettergrade = 'Z';
        return lettergrade;
}

---

Or even without else (and without temp var):

Code:

---

char convertGrade(int numGrade)
{

        if  ((numGrade >= 90) && (numGrade <= 100))
        {       
                return 'A';
        }
        else if ((numGrade >=80) && (numGrade <=89))
        {       
                return 'B';
        }
        else if ((numGrade >=70) && (numGrade <=79))
        {
                return 'C';       
        }
        else if ((numGrade >=60) && (numGrade <=79))
        {               
                return 'D';
        }
        else if ((numGrade <=59) && (numGrade >=0))
        {       
                return 'F';
        }

        /* incorrect grade */
        return 'Z';
}

---

Code:

---

#include <stdio.h>
#include <math.h>

int getScore();
char convertGrade();
void showGrade(int numGrade, char lettergrade);


int main(void)
{
        int numGrade;
        char lettergrade;

        numGrade=getScore();
        convertGrade();
        lettergrade=convertGrade();
        showGrade(numGrade, lettergrade);

        return (0);

}

int getScore()
{
        int numGrade;

        printf ("Please enter your numeric grade> ");
        scanf ("%d", &numGrade);
        return numGrade;

}



char convertGrade(int numGrade)
{
        char lettergrade;


        if  ((numGrade >= 90) && (numGrade <= 100))
        {        lettergrade = 'A';
        return lettergrade;
        }

        else if ((numGrade >=80) && (numGrade <=89))
        {       
                lettergrade = 'B';
                return lettergrade;
        }

        else if ((numGrade >=70) && (numGrade <=79))
        {
                lettergrade = 'C';
                return lettergrade;       
        }


        else if ((numGrade >=60) && (numGrade <=79))
        {               
                lettergrade = 'D';
                return lettergrade;
        }

        else if ((numGrade <=59) && (numGrade >=0))
        {       
                lettergrade = 'F';
                return lettergrade;
        }

        else
        {       
                lettergrade = 'Z';
                return lettergrade;
        }

}

void showGrade(int numGrade, char lettergrade)
{
        if (lettergrade=='Z')

                printf ("Your score of %d is invalid grade", numGrade);
        else
                printf ("Your score of %d is %c grade", numGrade, lettergrade);
}

---

how about now?

look at this:

Code:

---

char convertGrade();
char convertGrade(int numGrade)

---

Notice the difference?
The place where you call the fucntion should be also fixed