Duplicate definition.

I am missing something obvious here.

Code:

---

#ifndef A_H
#define A_H

namespace outer
{
        namespace inner
        {
                class A
                {
                private:
                        int aint;
                public:
                        int getaint(void);
                };

                A a;
        }
}
#endif // A_H

---

So I build a declaration and definition of "a", an object of type A in the outer::inner:: scope.

Code:

---

#include "a.h"

namespace outer
{
        namespace inner
        {
                int A::getaint(void)
                {
                        return aint;
                }
        }
}

---

Implement the method.

Code:

---

#include <iostream>
#include <string>

#include "a.h"

int main()
{
        std::string x;

        std::cout << outer::inner::a.getaint() << std::endl;

        std::cin >> x;

        return 0;
}

---

Run it.

No, it doesn't link.

LNK2005: "class outer::inner::A outer::inner::a" (?a@inner@outer@@3VA@12@A) already defined in prog.obj

It recognises the type of "a" which is instantiated in the header, yet it claims to find another instance of "a" somewhere. I wondered if it was taking the attempt to invoke the method as a definition rather then an action, but if that was the case, it would surely have created a typeless variable in the outer::inner:: namespace.

A is a type name, but a is an object name, that of an object of type A. One solution is to declare a as extern, and then define it in the source file.

However, if you do not actually need a global variable, do not have one to begin with.

Never put any variables or objects in header files (unless it's a constant integer). The solution is, as laserlight implies, to put the actual variable or object in a source file and add the name and type of that variable along with extern in the header.

The example I posted is a mercilessly cut down fragment to demonstrate an issue which is cropping up all over an inherited projected consisting of about 70 headers and perhaps 50 source files most stretch for pages, some are encyclopedic in size.

Yes, a is an object of type A, but there is only a single instance of a. I'm still curious where the duplicate is in my sawn off example.

IF you include that header in several .cpp files, each source file will have an instance of the very same name and type, thus the linker complains because it's not allowed.

But those 3 files I pasted above, if you try to compile them together, no other files, generate the error message I posted.

Again,

Code:

---

namespace outer
{
        namespace inner
        {
                A a;
        }
}

---

The offending line is in the header.
Put that inside a source file, then do

Code:

---

namespace outer
{
        namespace inner
        {
                extern A a;
        }
}

---

In the header.

Unless you've updated the source and haven't shown us?

Each cpp is compiled separately as one compilation unit. Both cpp files include "a.h". Each time you compile a source file that includes "a.h", A a is going to be seen by the compiler. Header guards guard against multiple inclusions from the same compilation unit, but between compiling each source file the compiler "forgets" all defined preprocessor macros.

As a result the global object a is defined in both object files.

Solutions have been already suggested.

Quote:

---

Each cpp is compiled separately as one compilation unit. Both cpp files include "a.h". Each time you compile a source file that includes "a.h", A a is going to be seen by the compiler. Header guards guard against multiple inclusions from the same compilation unit, but between compiling each source file the compiler "forgets" all defined preprocessor macros.

As a result the global object a is defined in both object files.

---

Ah, now THAT answers my question. Cheers.