Accepting decimal numbers

Hi,

I'm having some trouble with code, trying to make my function to be able to accept decimal numbers.

But it somehow cannot accept the decimal numbers. It has to be able to accept the decimal number.


Here's a sample input to test my code:
Simpson,Homer,6,2,1,7,5.3

When the decimal number isn't accepted, it prints out "bad"

Here's my code:

Code:

---

#include <stdio.h>
#include<iostream>
#include<iomanip>
#include<sstream>
#include<fstream>
#include<string>
#include<cctype>

using std:: cout;
using std:: cin;
using std:: endl;
using namespace std;


bool validation(string& s);
bool input(string& s);


int main()
{
        string text;
        input(text);
       
        return 0;
}

bool validation(string& s)
{
        int flag = 0;

        for(string:: size_type i=0; i<s.length(); i++)
        {
                if(!isalpha(s[i]) && s[i] != ',' && !isdigit(s[i]))
                {
                        cout << "bad" << endl;
                        return false;
                }
               
                if(isalpha(s[i]) && s[i] == ',')
                {
                        if(isdigit(s[i]))
                                flag = 1;
                        else
                                flag = 1;
                }
                else
                        flag = 0;
        }

        if(flag == true)
        {
                cout << "ok" << endl;
                return true;
        }
        return 0;
}

bool input(string& s)
{
        string line;
        string inputText;

        istringstream iss;
        cout << "Please enter text\n" << endl;
        while(getline(cin, line))
        {
                iss.clear();
                iss.str(line);

                if(iss >> inputText)
                {
                        validation(inputText);
                        cout << "\n\n" << "text"  << endl;
                }
        }
        return true;
}

---

Your validation function checks the string to see if it is an integer. You have to add extra code to allow for the decimal point (and possible other things) if you want it to allow decimals as well. Usually whole numbers (called integers) and decimal numbers (called floating point numbers) are validated separately because there are different types in C++ to hold those two types of numbers (int and double are the default types for integers and floating point numbers).

Also, streams already do validation like this. So unless you have an assignment to write the validate function, you should just use the streams which work very well. To use the stream, you first have to have a variable of the type you expect. Then you read into that type and check the return value. For example, this validates a decimal number:

Code:

---

double decimal_num = 0.0;
if (!(iss >> decimal_num))
  cout << "bad" << endl;

---

thanks

but is there a way where my "validation" function can validate whether it is a decimal or not.

Of course. Decide what your willing to accept for "decimal": does .7 work? What about 7? What about 7.? Once you know what you're willing to take, then you can code that into your function.

Code:

---

                        if(isdigit(s[i]))
                                flag = 1;
                        else
                                flag = 1;

---

Huh?

Also, as a habit, instead of this:

Code:

---

        for(string:: size_type i=0; i<s.length(); i++)

---

use something like this:

Code:

---

        size_t len = s.length();
        for(string:: size_type i=0; i<len; i++)

---

This avoids calling the s.length() for every iteration of the loop.

And as the others pointed out, you should check for a decimal point (and perhaps + and - as well) in when checking if it's a floating point number.

--
Mats