free() Memory Question

Hello to all.

Is this program licking memory?

Code:

---

int main()
{
      while(i<100)
      {
            ...
            printf("Example &#37;s\n",function());
            ...
            i++;
      }

      return 0;
}

char* function ()
{
      char* data;
      ...
      data = "memory";
      ....
      return data;
}

---

Thanks!

No.

If it were to actually compile and run, it would only be using the program stack.

isn't 100,000 out of bounds for an integer? thought it was 16,000, unless i'm the dinosaur;->

Quote:

---

Originally Posted by rogster001

isn't 100,000 out of bounds for an integer? thought it was 16,000, unless i'm the dinosaur;->

---

For a 2 byte integer, yes. For a 4 byte integer, no.

The code is flawed.
1) It never calls the function, instead it prints the actual function address which is not a string. You may very well get junk or a crash.
2) The function "function" returns a pointer to local data. I'm not sure if it might just return a proper string, but I wouldn't bet on it.
3) It should be const char*, not char*.
4) i is never defined.

Quote:

---

Originally Posted by Elysia

The code is flawed.
1) It never calls the function, instead it prints the actual function address which is not a string. You may very well get junk or a crash.
2) The function "function" returns a pointer to local data. I'm not sure if it might just return a proper string, but I wouldn't bet on it.
3) It should be const char*, not char*.
4) i is never defined.

---

You forgot one.

Quote:

---

Originally Posted by guillermoh

Hello to all.
Is this program licking memory?

---

RAM is a terrible thing to taste. :D

Quote:

---

2) The function "function" returns a pointer to local data. I'm not sure if it might just return a proper string, but I wouldn't bet on it.

---

Do I need to malloc()?

you need to call function like
function()

Quote:

---

you need to call function like
function()

---

Sorry. typing mistake

Quote:

---

Originally Posted by guillermoh

Do I need to malloc()?

---

Most likely, yes. Then you need to free.

Quote:

---

Originally Posted by Elysia

Most likely, yes. Then you need to free.

---

Why if he needs only to return some const string?

Does this solve my problems?

Code:

---

int main()
{
      gchar *string;
      while(i<100)
      {
            ...
            string = function();
            printf("Example &#37;s\n",string);
            free (string);
            ...
            i++;
      }

      return 0;
}

char* function ()
{
      char* data = "";
      ...
      data = concatenate(data,"memory");
      ....
      return data;
}

char * concatenate (char* str1, char* str2)
{
        char *result;
        if ( str2 != NULL )
        {
                result = malloc(strlen(str1) + strlen(str2) + 1);
                if ( result != NULL )
                {
                        strcpy(result, str1);
                        strcat(result, str2);
                }
        }
        return result;
}

---

Quote:

---

Originally Posted by guillermoh

Does this solve my problems?

---

Depends on what is your problem

Currently this code is more complicated without a gain

I'm trying to solve this:

Quote:

---

1) It never calls the function, instead it prints the actual function address which is not a string. You may very well get junk or a crash.
2) The function "function" returns a pointer to local data. I'm not sure if it might just return a proper string, but I wouldn't bet on it.

---