Warning Error

My program compiles and works correctly, but I have this warning:

Warning W8027 workingArea2.cpp 76: Functions containing for are not expanded inline

what does that error mean ?

Code:

---

#include <iostream>
using namespace std;

class CRectangle
{
      private:
  int x;
  string y;


  public:
    void set_values (int,string);

       
       
       
        string check()
        {

          int flag = 0;
         
                if (x!=4)
                        cout << "false"<<endl;
                else
                        for(int i=0;i<x;i++)
                        {
                                if (y[i]=='4')
                                {
                                        cout << "correct"<<endl;
                                        flag = 1;
                                }
                        }
                       
                        if(flag == 0){
                       
                        cout<<"incorrect"<<endl;
                        }

                return  y;
        }
       
        string check2()
        {
                }
};


       
void CRectangle::set_values (int a, string b) {
  x = a;
  y = b;
}

int main () {
         
        int length;
        string codeNumber;
  string mystr = codeNumber;
       
       
        cout << "Insert a code of 4 characters:";
        cin >> codeNumber;
        length = codeNumber.length();
 
  CRectangle rect;
  rect.set_values (length,codeNumber);
    rect.check();
  return 0;
}

---

There is no line 76, so I have no idea what you are talking about.

Also, please indent your code consistently.

oh my bad! it is line 26
Warning W8027 workingArea2.cpp 26: Functions containing for are not expanded inline

Code:

---

                for(int i=0;i<x;i++)
                        {
                                if (y[i]=='4')
                                {
                                        cout << "correct"<<endl;
                                        flag = 1;
                                }
                        }

---

Learn to split class definition and implementation.
Also learn to indent properly.
Click the link. Read. Absolutely no ignoring, okay? Very important information. Things that you need to know. That sort of stuff.

It probably just means that it's that particular compiler's policy to never inline functions containing a for loop, therefore check() will not be inlined, even though you put its definition inside the class definition, which means you're requesting that it be inlined.

Funny, but I'm compiling with -Wall -Wextra -Werror -pedantic and I don't get that error.

The warning message is pretty clear : if you have a for-loop in a function, the compiler can not inline the function. Member functions declared inside the class declaration will automatically be classed as "inline functions" - so the compiler tells you that "you asked [implicitly by putting it in the class declaration] that this function should be inlined, but I'm not doing it, because of the for-loop".

--
Mats

Pretty useless warning, that. What compiler is this? Borland or Intel?

I don't know how bad it is to inline that particular function, the importance of that issue seems like nothing next to the rest of the issues going on here...

Well, the compiler is not required to inline a function even when you tell it to, so that warning can be ignored.

Quote:

---

Originally Posted by CornedBee

Pretty useless warning, that. What compiler is this? Borland or Intel?

---

Using google, it appears that this warning is issued by some Borland compilers - and I agree, it's pretty useless warning - [and it's a pretty silly rule too - why can't a for-loop be inlined?]

But the warnin gmessage itself isn't particularly cryptic. The ones that say "lvalue required" or "expected integer" are often harder to figure out for the novice. I think it's the implicit inline that is part of the original poster's difficulty to understand the message.

--
Mats

Quote:

---

it's a pretty silly rule too - why can't a for-loop be inlined?

---

I think it is less a matter of "I cannot do it" and more "I decided not to do it".

Quote:

---

Originally Posted by laserlight

I think it is less a matter of "I cannot do it" and more "I decided not to do it".

---

Sure, but it's still a "silly" decision - at least for modern systems.

--
Mats

aama100 take a look at this:

Code:

---

#include <iostream>
using namespace std;


class CRectangle
{
        public:
   
                    void set_values(int, string);
                string check();
                string check2();
               
        private:
       
                int x;
                string y;
};


void CRectangle::set_values (int a, string b)
{
          x = a;
          y = b;
}


string CRectangle::check()
{
        int flag = 0;
         
        if(x != 4)
        {
                cout << "false"<< endl;
        }
               
        else
        {
                for(int i=0; i<x; i++)
                {
                        if(y[i] == '4')
                        {
                                cout << "correct"<<endl;
                                flag = 1;
                        }
                }
                       
                if(flag == 0)
                {
                        cout<<"incorrect"<<endl;
                }
        }

        return  y;
}


int main () {
         
        int length;
        string codeNumber;
          string mystr = codeNumber;
       
        cout << "Insert a code of 4 characters:";
        cin >> codeNumber;
        length = codeNumber.length();
 
          CRectangle rect;
          rect.set_values (length,codeNumber);
        rect.check();
 
          return 0;
}

---

Do you see the difference? Listen to what Elysia has told you, not only about indentation, but about leaning to use classes as well.

Ask yourself: what am I doing here? -before you start hammering out code.