Need Help!!!!!!!!!

I am having trouble reading a file.
The file constists of one positive integer on a line.
ex.
1
2
3
4
5
....
And the code I wrote prints off really really weird numbers, any help?

Code:

---

#include <stdio.h>

int main(){

        FILE *fp;
        int c;
        char loc[] = "readThisFile.txt";

        if(!(fp = fopen( loc, "r"))){
                perror("fopen");
                printf("Error: File could not be opened");
                return 0;
        }
       
        while( (c = getc( fp ) ) != EOF ){
                printf( "%d\n", c);
        }

        printf("\ndone\n");
        getchar();
}

---

Well you are getting characters from the file that would be read as ascii then putting the values in an int. Maybe try:

Code:

---

        while( (c = getc( fp ) ) != EOF ){
                printf( "%d\n", c-'0');
        }

---

that kind of works, but my output now looks like:

5
-38
3
-38
1
2
-38
.....


I just want it to be like
5
3
12
...

Perhaps...
printf( "%c\n", (char)c) ;
...works.

Well it would probably be best to get each line as a string then convert to an integer using strtol, or atoi. Thats how I would do it.

Edit:

Quote:

---

Perhaps...
printf( "%c\n", (char)c) ;
...works.

---

But wouldent 12 get split into 1 and 2 then?

If the data was to converted into a number from the beginning. That remains to be seen.

Quote:

---

Originally Posted by mike_g

Yeah it would work better but then 12 would still be split into 1 and 2.

---

How so? Getc reads a character from the stream or returns EOF if end-of-file. So you should convert it back to char before printing it.
I'm wondering if you shouldn't use fgetc, as well. Don't know the difference between them.

no dice... :(

Code:

---

        while( (c = getc( fp ) ) != EOF ){
          li = atoi(c);
          printf("%d\n",li);
        }

---

You're printing numbers. You need to print characters, try my example.

well I tried your method Elysia, but it dident come out right. I came up with a crude hack that seems to work:

Code:

---

int sum =0;
while( (c = getc( fp ) ) != EOF )
 {
    if(c != '\n')
    {
        sum *= 10;           
        sum += c-'0';
    }
    else
    {
        printf( "%i\n", sum) ; 
        sum = 0;
    }
}

---

That's certainly weird, because it works for me:

Code:

---

        fopen_s(&f, "C:\\test.txt", "r");
        for (;;)
        {
                c = getc(f);
                if (c == EOF) break;
                printf("%c", (char)c);
        }
        fclose(f);

---

File contents: This is a test
Output: This is a test

Well using this:

Code:

---

        while( (c = getc( fp ) ) != EOF )
                printf( "%c\n", (char)c) ;

---

In the original code each character comes out on a new line, with extra newlines added.


[edit] Its beacuse you were putting the \n in the printf for each character, like what I said ;)

But that's because the format is "%c\n". The OP is breaking each character into a newline.
Perhaps that is a bad thing considering that the code is also reading newlines and printing them.

In such case,

Code:

---

        while( (c = getc( fp ) ) != EOF )
                printf( "%c", (char)c) ;

---

Might be better.

Yeah that works fine and its much more compact than my version, but it dosent convert it to an integer.

Also, out of curiosity, is there any need for the char cast?

It seems it doesn't. All values are pushed onto the stack as 4-byte values, of course.

Maybe it's better to use fscanf than getc here.
for example:

Code:

---

#include <stdio.h>

int main(){
        FILE *fp;
        int c;
        char loc[] = "readThisFile.txt";

        if(!(fp = fopen( loc, "r"))){
                perror("fopen");
                printf("Error: File could not be opened");
                return(1);
        }
       
        while( !feof(fp) && fscanf(fp, "&#37;d\n", &c) != 0){
                printf( "%d\n", c);
        }

        printf("\ndone\n");
        getchar();
        return(0);
}

---