Any improvments that i could make to this program?

Code:

---

#include <iostream>

using namespace std;

int main()

{
    cout<<"Software Version 1.0"<<endl;
   
    system("color ");
   
    system("title Average number finder");
   
    double dnumber1 = 0.0;

    double dnumber2 = 0.0;

    double dnumber3 = 0.0;

    double daverage = 0.0;

  cout<<"Please enter the number you would like averaged"<<endl;

  cin>>dnumber1;
  cin>>dnumber2;
  cin>>dnumber3;

      daverage =(dnumber1 + dnumber2 + dnumber3)/3;
     
      system("pause");
     
      system("cls");
 
      cout<<"The average:  "<< daverage<<endl;

      system("pause");

      system("cls");
      cout<<"Software Designer Mach1723"<<endl;

      cout<<"Software Version 1.0"<<endl;

      cout<<"Software Name Average Number Finder"<<endl;

      system("pause");
      system("cls");
      double dnumber4 = 0.0;

      double dnumber5 = 0.0;

      double dnumber6 = 0.0;

      double daverage1 = 0.0;
      cout<<"Please enter the number you would like averaged."<<endl;

      cout<<"if you dont wish to have number averaged again just exit the program"<<endl;

      cin>>dnumber4;
      cin>>dnumber5;
      cin>>dnumber6;

      daverage1 =(dnumber4 + dnumber5 + dnumber6)/3;

      system("pause");
      system("cls");

      cout<<"The average:  "<<daverage1<<endl;
     
     
system("pause");
system("cls");

}

---

any improvments anyone could think of?

Obviously you could use a loop to do the job more than one (or two) times.

Quote:

---

Originally Posted by anon

Obviously you could use a loop to do the job more than one (or two) times.

---

i have tried a loop but i cant get it to work right with my code it either just makes the code system pause repeat or just says the average over and over again

Then may-be post the code that you tried?

Heres the code i tried i dont even think i wrote it right

Code:

---

#include <iostream>

using namespace std;

int main()

{
      int x = 0;
    while ( x < 10 );
 
    cout<<"Software Version 1.0"<<endl;
   
    system("color ");
   
    system("title Average number finder");
   
    double dnumber1 = 0.0;
    double dnumber2 = 0.0;
    double dnumber3 = 0.0;
    double daverage = 0.0;
  cout<<"Please enter the number you would like averaged"<<x<<endl;
  cin>>dnumber1;
  cin>>dnumber2;
  cin>>dnumber3;
      daverage =(dnumber1 + dnumber2 + dnumber3)/3;
     
      system("pause");
     
      system("cls");
 
      cout<<"The average:  "<< daverage<<x<<endl;


      system("pause");
      system("cls");
}

---

Code:

---

while (condition)
{
        // Code here
        // More code here
}

---

Or

Code:

---

while (condition)
        // Code here

---

This is wrong:

Code:

---

while (condition);

---

Will result is an endless loop.

You should probably think of keeping your indentation consistent too. You're just indenting a little at will everywhere. Define a number of spaces (preferably 4) to serve as one indentation (or use a tab) and indent once for every block and only using the specified number of spaces and not more or less at some places.

Quote:

---

Code:

---

while (condition);

---

Will result is an endless loop.

---

not necessarily true.

Code:

---

int i = 10;
while (i--);

---

Oh, right, right! I was thinking of while (x > 10) or something like that!

You could define your software version and name information as constants at the top of the program.

You could comment your code.

You could not clear the screen so the user could see the numbers they entered to get the average.

You could tell the user that your program is looking for 3 numbers instead of one.

You could reuse variables instead of creating new ones.

You could tell the user HOW to cancel the program.

You could clear the screen before you start couting information.

You could capitalize your sentence and use an apostrophe in a proper contraction.

You could code "return 0;" since you're not but you say you are.

Todd

use functions or classes to have more managable code

Quote:

---

Originally Posted by Hussain Hani

use functions or classes to have more managable code

---

That's an overkill for something this simple

Would you write the code in the same way if you were averaging 10 numbers? How about 50?

Learn arrays. If you ever have more than 2 of the same thing that undergoes the same processing then it should be an array.

+ a loop will turn 50 variables into one.