scanf in bubblesort

here is my bubblesort code:

Code:

---

#include <stdio.h>

int N;
void swap(int *p, int *q)
{
    int tmp;
       
    tmp = *p;
    *p = *q;
    *q = tmp;
}

void bubble (int a[N])
{
        int i, j;
       
        for (i = 0; i < N; i++)
                for (j = N - 1; i < j; j--)
                if (a[j - 1] > a[j])
                        swap(&a[j - 1], &a[j]);
}

int        main (void)
{       
        int i;
        int a[N];
        printf ("Enter the amount of numbers to be sorted: ");
        scanf ("%d\n", &N);
        printf ("Enter your numbers:\n");
        for (i = 0; i < N; i++){
                scanf (" %d", &a[i]);}
        bubble (a);
        for (i = 0; i < N; i++)
        printf("%d ", a[i]);
        printf("\n");
        printf("\n");
        return 0;
}

---

what i can't understand is why main only calls printf ("Enter your numbers:\n") after the for loop and not before it as it is so in the code. any suggestions? also any ideas on how to re-declare N so it is not a global variable?

Like I said in your previous thread, newlines in scanf calls do NOT do what you think they should.

scanf ("%d\n", &N);

Also, this isn't the way to declare an N element array either.
You need to set a maximum size when you declare the array, then decide how many values you want to input.

For your global var, just define it in main and pass it as argument to any function that needs it.

ok cheers. i removed \n from scanf and it works now. yeah i do know that i didn't declare N properly. it has to be define N etc etc.