Split a String into Tokens

I am trying to split a string into tokens.
("file1.txt") contains this row: 12/04/2007,2111,35.23,35.23,35.20,35.22,15600,35.22

What I am trying to do now is to split this row up into tokens where the "," is the separator. The output that comes from this row will I put in ("file2.txt")

My code that I have tried to build look like this. I suppose I am on the right track but I cant find the ´wrong´ in the code.

Code:

#include "stdafx.h" #include <stdio.h> #include <string.h> #include <iostream> #include <fstream> #include <sstream> #include <string> int main() { char Rad[100]; char * Tecken; // ofstream Test; Test.open ("file2.txt"); ifstream myfile ("file1.txt"); // myfile >> Rad; // printf ("Splitting string \"%s\" into tokens:\n",Rad); Tecken = strtok (Tecken,","); while (Tecken != NULL) { printf ("%s\n",Tecken); Tecken = strtok (NULL, ","); Test << Tecken <<"\n"; } Return 0; }

1: Indent code properly, please.
2: myfile >> Rad is so unsafe. Try getline(myfile, Rad) instead (and make Rad std::string).

Code:

ifstream myfile ("file1.txt);

Missing " at the end of file1.txt.

Code:

Tecken = strtok (Tecken,",");

What do you suppose this does? Potentially a crash! Tecken isn't pointing to anything!

You could read in a line with getline, then put that string into a stringstream and read in each token with getline again, but using the stringstream and setting the delimiter to ',' instead of '\n'.

I have tried to do the changes mentioned about the delimiter, std::string and getline(myfile, Rad).
But still I haven´t figured it out if I am really doing right here.
I beleive I might have to see how this code could be written. Perheps using my code above wich also telling what I want to do and do the changes in that...
I beleive it is more simplier like that for me to understand. Then I can analyze what is happening in the code more easy.

I trying to solve my problem in another way. I have made a code below that works for taking the first characters out before the "First delimiter", in this case ',' . The line is as below:
12/04/2007,2111,35.23,35.23,35.20,35.22,15600,35.22

What I have done here with my code is to copy: 12/04/2007 to ("file2.txt").

Now is my Question this: How can I now instead assign: 2111 to the: std::string tal, wich comes After the First delimiter (',') ?
How could the code look like for this..
Thank You...

Code:

#include "stdafx.h" #include <iostream> #include <fstream> #include <sstream> #include <string> using namespace std; int main () { std::string tal; ofstream Test; Test.open ("file2.txt"); ifstream myfile ("file1.txt"); ifstream file0 ("file0.txt"); getline(myfile, tal, ','); Test << tal <<"\n"; return 0; }

Have you looked into using MFC? If you have a non-Express version of Visual Studio, then MFC is possible (though it won't be portable).

Code:

>Tecken = strtok (Tecken,",");

Change this to:

Code:

Tecken = strtok (Rad,",");

My version is: "Microsoft Visual C++ 2008 Express Edition". I don´t know to much about MFC so I dont know the reason you mentioned it, sorry.. I know I have Somthing called "Windows Forms Application". I dont know if this is something simular to MFC ?

I wonder still though how it is possible to solve the problem how to put "2111" in my last post...

Don't know. Express doesn't have MFC; it needs to be Standard or Professional, I believe. Non-free, of course, much to our disappointment.
MFC has so much better classes than the STL, which is why I mention it.

ok I understand. This is the first edition I use, so I dont understand all the differences between them yet.
I will try to work this out first and perheps I will change later to the Proffesional edition.. Thanks for your help !

Remember that it isn't free. I don't know much about the differences either, other than it comes with MFC.
MFC is great for native Windows programming; it also has lots of utility classes that's better than STL for professional developers; one I assume you are aiming to become.
Anyway, I'm sure someone else knows a lot more about C++ I/O than I do and can help.

Yes I aiming to be a professional developer ;) Actually as you are describing I am up to develop a special program in the end wich will be a "Windows application".
The things I am doing now is just basics stuff to understand the language.

Do you think it is to early for me to instead of using the edition I use now to continue with the C++ professional and focus more on building Windows applications with buttons, menus etc..

Perheps a difficult question to answer, I dont know :).
Someone told me before it is better to begin with simple consoleprograms to first understand the language better before starting to do "Windows applications programs/forms".

Thanks Elysia

Quote:

Originally Posted by Coding

I trying to solve my problem in another way. I have made a code below that works for taking the first characters out before the "First delimiter", in this case ',' . The line is as below:
12/04/2007,2111,35.23,35.23,35.20,35.22,15600,35.22

What I have done here with my code is to copy: 12/04/2007 to ("file2.txt").

Now is my Question this: How can I now instead assign: 2111 to the: std::string tal, wich comes After the First delimiter (',') ?

Keep reading? The rest of the line is still there (you only removed up to (and including) the comma). In other words, if you put another

Code:

getline(myfile, tal, ','); Test << tal <<"\n";

at the end, you should then see 2111 in your file2.txt.

Yes, you certainly need more experience with the basics; but the edition does not define what you can in sense of the language. The compiler is the same in all. The only thing that might be different is that you have MFC at your hands, which makes things easier.
With MFC, for example, you don't need to mess around with C-style functions such as strtok and things just to work with strings. MFC has a fully functional string class itself called CString that's far more useful than std::string.
I do myself use MFC and I'm very used to it which is also why I know so little of STL I/O and strings (and to know the truth, I frown at STL I/O and strings). That is why I recommend MFC if you want to program for Windows.

You can use whatever version and still continue with the basics...
Windows programming is the next step, after you learn the language.

I dislike strtok from the bottom of my heart. It is simply too easy to make errors with it.
If I was doing this, and if I had no performance limitations, I would coock up my own 'explode' function (as explode in php).
It would eat a string and delimiter, and return a vector<string> containing the pieces.

Simple way to do it would be:
read the whole thing in a string
place it in your own explode function

In function:

use string.rfind() to locate last ','.
use string.substr and vector.push_back to store the last piece in vector
use string.erase to remove the last piece from string.

repeat these untill every ',' is handled

store the first piece in vector.
[optional]
change the order of pieces in vector.

Great help Elysia... I will try to buy this version. I assume it is called: C++ Proffesional.
It really sounds what I will need after I have learned the basics etc... But still also for the basics why it sounds perfect... :)

A better name would be Split. I don't know why they chose such a stupid name for such a function.
But sure, you could make such a function. Good training and it's very easy.

Quote:

I will try to buy this version. I assume it is called: C++ Proffesional.

I... don't know about that.
Standard costs $280 and Professional costs $730, at least on the prices I could find on Newegg.
Haha... Very expensive.
Ehhh, well... Standard could be had, I guess. It's just the price for a commercial professional product.

ok, thanks I will search for these and see when I will get it :)

I don't see need for MFC here, nor is there any need to buy the Standard or Professional version of VC++. The solution is relatively simple with a stringstream and getline, and the learning curve for those features is probably smaller than for MFC.

As for your attempt, Coding, you are missing the stringstream part. You have to read a line into a string with getline from the file. Then put that string into a stringstream and read in each value with ',' from there.

I have succeded with a code that takes the First and Second value out of: 12/04/2007,2111,35.23,35.23,35.20,35.22,15600,35.22
wich is: 12/04/2007 and 2111

The second step after this is to tell for the code below: If Time == 2111 (wich it is)
it will write the Time to the file. I have tried to do an approch but it doesn´t work.
Perheps I have missed something here.

Code:

#include "stdafx.h" #include <iostream> #include <fstream> #include <sstream> #include <string> using namespace std; int main () { std::string Date; std::string Time; ofstream Test; Test.open ("file2.txt"); ifstream myfile ("file1.txt"); ifstream file0 ("file0.txt"); getline(myfile, Date, ',');// myfile >> tal; getline(myfile, Time, ',');// myfile >> tal; If (Time == 2111) // This is what I am trying to do here: If Time is 2111 wich it is in this case. { Test << Time <<"\n"; } return 0; }

Quote:

Originally Posted by Daved

I don't see need for MFC here, nor is there any need to buy the Standard or Professional version of VC++. The solution is relatively simple with a stringstream and getline, and the learning curve for those features is probably smaller than for MFC.

No, and of course not. I don't recommend buying Standard anytime soon, or at all. But MFC would be of help. The learning curve for this using MFC is much smaller I believe, though. But it seems it's not an option since the OP does not have Standard+.

Time is a string variable. If you want to compare it to something you have to compare it to "2111" (with the quotes) because that specifies that it is a string.

BTW, another option is if you know the exact format of your code (date as string,time as int,some other data as double,some other data as double,some other data as double,some other data as double,some other data as int,some other data as double), then you can read in with operator>> and then just read in the delimiters and ignore them.

Getline reads a full line of text - that is why it's called "getline" - so you get that entire line in one, then you get "nothing" in the next stage.

You also can't compre a string with a number. You probably want to split the string, and convert the parts into the right form of number.

--
Mats

>> Getline reads a full line of text
getline reads up to the delimiter specified, so if you specify ',' as the delimiter, it will stop at the first comma. It is called getline because the default delimiter is a newline.

I tried to compile with the "2111" before but this isn´t working.
As you say I want the Date to be a string ("") and the Time to be an Int.

So I have changed to this:
int Time = 0; //std::string Time;
and still using:
If (Time == 2111)

But still for my code above I have no compile success..

When you read in with getline, it reads in a string, so just changing Time to an int won't solve the problem. You have to read in as a string, then convert to an int.

This is what made me suggest the alternate approach of not using getline for the time.

You can use getline for the date, because it is a string and it is difficult to tell where the end of the date is unless you read it character by character.

Then, you can use operator>> to read in the Time. This will stop at the comma because a comma is not part of a number. It will allow you to make Time an int because operator>> works on ints.

Next, you'll have to remember to read in the ',' character. The getline function will read in and remove the comma it finds, but operator>> will not. So just make a dummy char variable and read the comma into that variable with operator>>. Then you will be able to continue and read in the rest of the data.

I follow your description but I am not sure practically how to do. I have experimented with some chars and >> but really dont understand the logic.

I have succeded and understand the logic of how to put Date as string and Time as Int like this:

getline(myfile, Date, ',');
myfile >> Time;

where the ',' is to follow for the Time(int) under this. But from here I dont know how to write the code really for the next value(35.23) in: 12/04/2007,2111,35.23,35.23,35.20,35.22,15600,35.22

I might need some codeassistance perheps...

You're doing fine. After the code you posted above, the input buffer looks like this:

Code:

,35.23,35.23,35.20,35.22,15600,35.22

Now just add another line using operator>> that reads into a char variable. This will read in the ',' character. Then the input buffer will look like:

Code:

35.23,35.23,35.20,35.22,15600,35.22

Then you can use operator>> to read into a double variable to store the 35.23. And so on...

I beleive this was my problem I am struggling with. I managed to do:
getline(myfile, Date, ',');
myfile >> Time;
myfile >> Comma; //Comma is: char Comma[50];

The output for: Comma in this case is: ,35.23,35.23,35.20,35.22,15600,35.22

If I understand you right here I ´just´ want to put the ',' in the char Comma using
>> and then a New line under this that reads in the: 35.23 using a double varibale.

I am not sure how I will write this. If you have the time I would appreciate how you would continue these 2 lines under:
getline(myfile, Date, ',');
myfile >> Time;

>> //Comma is: char Comma[50];
There's your problem.

A comma is a single character, but you declared the Comma variable as an array of 50 characters. It should just be a char, not a char array.

Daved,

That worked out really great... thanks for that.
Now when I am trying to do an if-statement like this, I have no compile success, though:
If Close == 35.23, where 35.23 is an integer. What could this depend on:

Code:

#include "stdafx.h" #include <iostream> #include <fstream> #include <sstream> #include <string> using namespace std; int main () { std::string Date; int Time = 0; char Comma; double Close = 0; ofstream Test; Test.open ("file2.txt"); ifstream myfile ("file1.txt"); ifstream file0 ("file0.txt"); getline(myfile, Date, ','); myfile >> Time; myfile >> Comma; //char Comma; myfile >> Close; If (Close == 35.23) { Test << Close <<"\n"; return 0; } }

>> I have no compile success, though
What compile error did you get?

Did you use If or if? Case matters in C++, make sure you spelled it as lower-case if.

Yes you solved my problem again... ofcourse I did it with a upper-case like this: ´If´
So the ´if´ do work now...
Thanks again Daved...

I propose you also learn proper indenting. Each block should be indented once.
You can also try to group your code into blocks - not necessary, but it also makes the code more readable.

Code:

#include "stdafx.h" #include <iostream> #include <fstream> #include <sstream> #include <string> using namespace std; int main() { std::string Date; int Time = 0; char Comma; double Close = 0; ofstream Test; Test.open("file2.txt"); ifstream myfile("file1.txt"); ifstream file0("file0.txt"); getline(myfile, Date, ','); myfile >> Time; myfile >> Comma; //char Comma; myfile >> Close; If (Close == 35.23) { Test << Close <<"\n"; return 0; } }

Correctly indented code. And don't mix spaces and tabs; it usually causes headaches for other editors (and the boards as well). Use only tabs or spaces. I recommend tabs.

Thanks for the tip Elysia. I will consider this when writing and post code !
I have come up with a new problem that I am trying to solve. I beleive I am quite near the solution I hope.
Before I had one row in a file(The first line/row below) that I was splitting into tokens and putting into variables.

12/04/2007,2111,35.23,35.23,35.20,35.22,15600,35.22
12/04/2007,2112,35.23,35.28,35.20,35.22,15600,35.22
12/04/2007,2113,35.23,40.00,35.20,35.22,15600,35.22

My next project below is for the Timevariable wich is for the rows: 2111,2112,2113 to make a new variable that finds the ´Highest Value´ of these and putting this to the Variable I have called: int HighestTim.
I beleive some new functions comes with this and I have tried to combine a whileloop with ! eof as could be seen in my code.
The code doesn´t work and I cant find what could be wrong. Am I on the right track.
(My code do compile success but doesn´t write the variable: HighestTim to the file: Test)

Code:

#include "stdafx.h" #include <iostream> #include <fstream> #include <sstream> #include <string> using namespace std; int main () { std::string Date; int Time = 0; // int HighestTim = 0; ofstream Test; Test.open ("file2.txt"); ifstream myfile ("file1.txt"); ifstream file0 ("file0.txt"); getline(myfile, Date, ','); // 12/04/2007 myfile >> Time; // 2111 while ((! myfile.eof()) & (Date == "12/04/2007") & (Time > Time)) { HighestTim = Time; } if (HighestTim > 2111) { Test << "Test " << HighestTim <<"\n";} return 0;}

Here we go again... Correctly indenting code:

Quote:

Originally Posted by Coding

Code:

#include "stdafx.h" #include <iostream> #include <fstream> #include <sstream> #include <string> using namespace std; int main () { std::string Date; int Time = 0; // int HigherTim = 0; ofstream Test; Test.open ("file2.txt"); ifstream myfile ("file1.txt"); ifstream file0 ("file0.txt"); getline(myfile, Date, ','); // 12/04/2007 myfile >> Time; // 2111 while ((! myfile.eof()) & (Date == "12/04/2007") & (Time > Time)) { HigherTim = Time; } if (HigherTim > 2111) { Test << "Test " << HigherTim <<"\n"; } return 0; }

Also note that & will not do what you think it will. It's a binary OR operator, not the AND operator. That's &&. Two & after each other.
And I generally do not recommend such complex loop conditions, because it's hard to read and easy to make mistakes.
Instead, what I do, is make an infinite for loop and check conditions in the loop manually and then break if if true. And using eof() as a loop condition is generally bad; you should read the FAQ about that:

Code:

for(;;) { if (condition) break; }

The new loop is a good idea. But you shouldn't use eof() to control the loop. Instead, check the return value of the read operation to make sure it succeeded.

In your case, you want the getline and the myFile >> Time to be part of the loop because you want them to be repeated for each line, right? So you have to move them to the loop. I would put the very first read (in this case getline(myfile, Date, ',')) inside the while control like this:

Code:

while (getline(myfile, Date, ','))

That will allow the while loop to break when there are no more Dates in the file that can be read in.

You also need to code to read in the rest of each line and ignore it. How you do that is up to you, but one way is to call getline and read into a dummy variable with '\n' as the delimiter. That will read in and ignore the rest of the line. If you need to read in and use the data in the rest of the line obviously you wouldn't want to do that.

Quote:

Originally Posted by Daved

Code:

while getline(myfile, Date, ','))

Code:

while (getline(myfile, Date, ','))

:)
You forgot a parenthesis.

This got me a bit confused, I understand the logic you are describing to move the getline and >> inside the loop to repeat for the lines that comes under.
I suppose both the ´Time´and ´Date´should be put into the same while loop.
But from there I am stuck. I cant really understand how the code will be build enterily.
I have tried out an example below but something might be wrong with it.

(I have removed the getline and >> and instead put it inside the while loop. I suppose it only should be inside the loop.)

Code:

while (getline(myfile, Date, ',') myfile >> Time) { if Time > Time { HighestTim = Time; }} if (HighestTim > 2111) { Test << "Test " << HighestTim <<"\n"; } return 0; }

Coding, have you taken a second look at all the code you post?
All are very hard or confusing to read because you're misusing indentation and spaces.
Try to reform that last code you posted into something more readable.

This is kind of a confusing area. Ideally, you should have the getline and myfile >> Time calls inside the loop itself (inside the curly braces, not the parentheses).

However, you need some method of breaking the loop when no more input is found.

My suggestion was to put only the getline part inside the parentheses. It will still get called each time, but it will cause the loop to break when there is no more input.

It works better than the eof() loop you had originally because eof() isn't always true when the file has no more data in it.

So my suggestion is to put the getline inside the while control (inside the parentheses like in my example), and then put the myfile >> Time part and the rest of the code inside the loop itself (inside the curly braces).

Once you do that, you'll have to fix up the rest of the code inside that loop. I would try removing everything else and just get the reading part to work. You'll also have to add code to read the rest of the line like I mentioned before.

Now I have understand the logic of how the getline and where myfile >> should be placed wich also will break when there is no more input.

I have also completed the input for the lines I will read in. The thing is that I need every single value on the line as I have coded below, so I don´t want to ignore any of these data.
So the code look like this for the while loop. Still there is something I dont understand.
Perheps I should need some code assistance in order to understand what is happening...
Thanks..

Code:

while (getline(myfile, Date, ',')) { myfile >> Time; // 2111 myfile >> Comma; myfile >> Open; // 35.23 myfile >> Comma; myfile >> High; // 35.23 myfile >> Comma; myfile >> Low; // 35.20 myfile >> Comma; myfile >> Close; // 35.22 myfile >> Comma; myfile >> Volume; // 15600 myfile >> Comma; myfile >> Close; // 35.22 if Time > Time { HighestTim = Time; Test << "Test " << HighestTim <<"\n"; return 0; }}

Your reading code looks good. There is only one minor problem that you might have left which is that some of the Date fields might have an extra newline character at the start. If you notice this, then add myfile.get(); like this:

Code:

myfile >> Close; // 35.22 myfile.get(); // read in trailing newline character

Now, what is it that you don't understand? Your if statement has incorrect syntax. I assume you're trying to remember which is the highest time value. If so, then you have the right idea, except you have to fix your if statement. You have code in there that should be after the while loop.

Here I am again.. sorry Daved... I beleive I am close to the solution but dont understand why I have no compile success. The code looks as below. I have put the if statement after the loop as you said.
I did a mistake for the if statement, it should ofcourse be: if Time > HighestTim...

When I run the code I have these errors and all variables are declared. Perheps there is any detail missing still.
.\Test.cpp(45) : error C2061: syntax error : identifier 'Time'
.\Test.cpp(46) : error C2143: syntax error : missing ';' before '{'

Code:

myfile >> Volume; // 15600 myfile >> Comma; myfile >> Close; // 35.22 myfile.get(); // read in trailing newline character } // while loop braces if Time > HighestTim { HighestTim = Time; Test << "Test " << HighestTim <<"\n"; return 0; } } // int main braces

You are missing parentheses in the if statement. You really gotta work on the basics, here.

Code:

if (condition) { code; }

Is it just me or are you COMPLETELY ignoring my suggestions about fixing your code mess?

Yes, you are right about that.. i forgot it... but still the function to find the "Highest Time Value" doesn´t work...
I do have compile success now but with the code above I have no output to the file: Test

Look at the code inside the if block. Should that code really be there?

Also, it's hard to find exact problems without the latest, complete code. Maybe you can fix up all your indentations and post the latest complete code so we can have a better picture of what is going on.

Elyisa, I am defenetively not ignoring your suggestions. Remember I am a quite of a beginner with this compared to you... my code doesnt look like a mess that you said.. but not perfect though...
But I am trying better and better... The tabs doesn´t really work out 100 % for me why the code could look a bit like that... but the important is that I am trying.. please have patience...

I understand, but indentation is not a difficult thing and from what I can see, all posts look the same.
Try to fix up the code mess into something more readable. It will be better for yourself and for others when they read your code too.

Thanks Elysia...I will do that...trust me I am trying. Many things to think of in the begining ;)

So, you should really un-indent your if-line to the same level as the while above it, as it's at the same level. And look at the code inside the if-statement - what does it actually do?

--
Mats

This is my complete code (I hope this is more readable, good for me to know if it´s not. Thanks!)
I think the code inside the if statement (if (TIme > HighestTim) should be there as if it finds a higher value
of the time that is "saved" or by default in the variable: HighestTim. Then the current Time that is red will replace this value with this higher TimeValue ?

Code:

#include "stdafx.h" #include <iostream> #include <fstream> #include <sstream> #include <string> using namespace std; int main () { std::string Date; int Time = 0; char Comma; double Open = 0; double High = 0; double Low = 0; double Close = 0; int Volume = 0; int HighestTim = 0; ofstream Test; Test.open ("file2.txt"); ifstream myfile ("CCE.txt"); ifstream file0 ("file0.txt"); while (getline(myfile, Date, ',')) { myfile >> Time; // 2111 myfile >> Comma; myfile >> Open; // 35.23 myfile >> Comma; myfile >> High; // 35.23 myfile >> Comma; myfile >> Low; // 35.20 myfile >> Comma; myfile >> Close; // 35.22 myfile >> Comma; myfile >> Volume; // 15600 myfile >> Comma; myfile >> Close; // 35.22 myfile.get(); // read in trailing newline character } if (Time > HighestTim) { HighestTim = Time; Test << "Test " << HighestTim <<"\n"; return 0; } } // int main braces

Yep, much better!
You probably don't need to indent so much, though, because it will make your code zillioningly long when you have a lot of blocks! Just one tab or 4 spaces are usually enough.
You also missed indenting inside that while.

Otherwise it looks very good!

Thanks Elysia. I beleive you meen like that inside of the while. If it is... Then I should know now how it should be done :)

You are doing two different things inside your if block. One, you are checking to see if the Time is greater than the current highest value. Two, you are printing out the highest time that was found. But checking the current time to see if it is the highest is something that should be done while you are reading in the times, right? And printing out the highest should only be done at the end after all times have been read in, right?

Quote:

Originally Posted by Coding

Thanks Elysia. I beleive you meen like that inside of the while. If it is... Then I should know now how it should be done :)

That's the ticket! Now it looks very nice!
Now you just have to hunt down those bugs in the code ;)
Also note that main should always return a value and so by putting it inside that if block, it will only return something if the condition is true. Not a good thing, is it? If that condition is false, then main won't return (an explicit) value. You should also get a warning (at least in C++) saying that not all control paths return a value. Move that return outside the if. I don't think you actually was intending to return 0 only if the condition was true, did you?

>> You should also get a warning (at least in C++) saying that not all control paths return a value.
Technically you should not get a warning if you don't include a return value at the end of main. There is a rule in C++ that allows you to leave out the return statement and the compiler will implement a return 0 automatically.

Of course, using a return value inside the if and not after it is confusing even if it is technically correct, so the advice is still appropriate.

Yes, but also, typically, if you return something within one possible path of the function and not another, you should also get a warning. Though I don't know if that applies to main since it's allowed to not explicitly return something.

Thats right Elysia.. True, I will put return outside the if statement.

And it´s right about the if condition it should ofcourse be inside the while loop as it in realtime searching for the greatest timevalue.
Now it works and I appreciate all help that I got. I will now experiment and learn all the logics with the code, and the indentations.. Take care...;)

Don't leave us! Keep pestering us with more questions! :D
That's what we live for, that's what we sit before the computer for, that's where we get all our posts from! :p

Alright, good luck.

Did you put the entire if block into the while loop? Is that what you really want to do?

Thanks for that Elysia.. I am happy to hear that. I will ofcourse keep send you questions. I really appreciate it. Dont worry :P
I have been sitting with a problem for 20 hours myself searching on the internet and thinking about a solution but cant solve this. I beleive that what I want to do is a bit special, perheps there are functions/syntax to help this problem out.
Actually it is 2 things/questions that is happening at the same time.
But I will start out with the first question to see if the first thing could be solved to not make it to difficult.
.................................................. .................................................. ..........................................
Here we go :)
What I want to do now as I can scan a file and find the lowest value for example "Low" for the entire file. As the example below with 4 lines that contains 2 different dates. I want to store the Lowest Value of Low for each date into a variable. The two variables I have named: "IntraLow9" and "IntraLow8".

01/12/2006,2005,16.19,16.20,16.19,16.19,2100,16.19
01/12/2006,2006,16.20,16.20,16.20,16.20,200,16.20
01/13/2006,2005,16.20,16.20,16.18,16.20,1700,16.18
01/13/2006,2006,16.18,16.19,16.12,16.19,1500,16.19

As the code is scanning the file from the top to bottom I have managed to do a code that do a count when a new date occurs.(´Perheps´ this will be of help for the solution)
The variable is called: "DateCount" and counts down from 11. This meen when the first date happens in the file it will have a count of 9 and for the other date 8.

So the first key for the first date is 9 then. What I want to do now is to store the lowest value of Low into the variable called: IntraLow9
I know that my approach: (IntraLow + DateCount) is wrong but perheps you understand what I am ´trying´ to do. (It is kind of "Intelligent" assignment to variables)

How could it be possible to do something like this ? (Hope you can understand my explanation of the problem :) )

Code:

#include "stdafx.h" #include <iostream> #include <fstream> #include <sstream> #include <string> using namespace std; int main () { std::string Date; std::string DateDummy; double DateCount = 11; double IntraLow9 = 1000; double IntraLow8 = 1000; char Comma; int Time = 0; double Open = 0; double High = 0; double Low = 0; double Close = 0; int Volume = 0; double IntraHigh = 0; double IntraLow = 1000; double IntraVolume = 0; ofstream Test; Test.open ("file2.txt"); ifstream myfile ("CCE.txt"); ifstream file0 ("file0.txt"); while ( getline(myfile, Date, ',') ) { myfile >> Time; // 2111 myfile >> Comma; myfile >> Open; // 35.23 myfile >> Comma; myfile >> High; // 35.23 myfile >> Comma; myfile >> Low; // 35.20 myfile >> Comma; myfile >> Close; // 35.22 myfile >> Comma; myfile >> Volume; // 15600 myfile >> Comma; myfile >> Close; // 35.22 myfile.get(); // read in trailing newline character if ((Low < (IntraLow + DateCount)) && (DateCount != 11) && (Date == DateDummy)) // I am trying to make the code understand { // that (IntraLow + DateCount) meens: IntraLow9 where DateCount (IntraLow + DateCount) = Low; // for the moment is 9 and then put the lowest value for the } // date into double IntraLow9. ////////////////////////////////////////////////////////////////////// if (Date != DateDummy) { DateDummy = Date; DateCount = (DateCount - 1); // DateCount has a CountDown for the Dates ´while´ the code is running. Starting at 11 } ////////////////////////////////////////////////////////////////////// } // End of While Statement Test << IntraLow9 <<"\n"; return 0; } // int main braces

You probably need to learn arrays for this. I would actually use a map and map the date string to the current low value. If the times will always be greater than 0 then this is really easy once you learn how to use the map.

I'd also consider starting a new thread, since this one will be hard to follow for anybody who hasn't been doing so already.

Quote:

Originally Posted by Coding

Here we go :)
What I want to do now as I can scan a file and find the lowest value for example "Low" for the entire file. As the example below with 4 lines that contains 2 different dates. I want to store the Lowest Value of Low for each date into a variable. The two variables I have named: "IntraLow9" and "IntraLow8".
[snip]
So the first key for the first date is 9 then. What I want to do now is to store the lowest value of Low into the variable called: IntraLow9
I know that my approach: (IntraLow + DateCount) is wrong but perheps you understand what I am ´trying´ to do. (It is kind of "Intelligent" assignment to variables)

How could it be possible to do something like this ? (Hope you can understand my explanation of the problem :) )

The quick'n'dirty way to do this would be arrays, I would think. Use IntraLow[DateCount] instead.

I'm sure the STL has many forms of associative arrays, and someone who actually knows the STL will be along to tell you; ten seconds of Google says that std::map might be something to look at.

Quote:

Originally Posted by Coding

Code:

if ((Low < (IntraLow + DateCount)) && (DateCount != 11) && (Date == DateDummy)) // I am trying to make the code understand { // that (IntraLow + DateCount) meens: IntraLow9 where DateCount (IntraLow + DateCount) = Low; // for the moment is 9 and then put the lowest value for the } // date into double IntraLow9. ////////////////////////////////////////////////////////////////////// if (Date != DateDummy) { DateDummy = Date; DateCount = (DateCount - 1); // DateCount has a CountDown for the Dates ´while´ the code is running. Starting at 11 } ////////////////////////////////////////////////////////////////////// } // End of While Statement

I'm not sure I understand your problem. Perhaps I simply need to re-read it, but even so, this is something I want to comment on. This is bad what you're doing.
You're actually putting the { in a indentation LESS than the if. { and } should always be on the same level as your block element, such as if, while, etc.
So indent those { and }, along with all the code inside.

Should look like this:

Code:

if ((Low < (IntraLow + DateCount)) && (DateCount != 11) && (Date == DateDummy)) // I am trying to make the code understand { // that (IntraLow + DateCount) meens: IntraLow9 where DateCount (IntraLow + DateCount) = Low; // for the moment is 9 and then put the lowest value for the } // date into double IntraLow9. if (Date != DateDummy) { DateDummy = Date; DateCount = (DateCount - 1); // DateCount has a CountDown for the Dates ´while´ the code is running. Starting at 11 } } // End of While Statement

Thanks.. I will read about arrays and maps through internet and also start a new thread later on...
Coding

There are excellent tutorials for that on this site. I think.
Anyway, check them out and see if they help.
std::vector and std::map are those you might want to take a look at.

Ok, thanks Elysia, I will take a look at them too..