final exam in the morning

Code:

---


#include <iostream>

using namespace std;

int main()
{
        const int SIZE = 5;
        int values[SIZE], counter, temp;
        bool swap;

       
        for (counter=0; counter<SIZE; counter++)
        {
                cout<<"please input a number"<<endl;
                cin>>values[counter];
        }

        do
        {        swap = false;
                for (counter=0; counter<values[counter-1]; counter++)
                {
                        if (values[counter+1]>values[counter])
                        {
                                temp=values[counter];
                                values[counter+1]=values[counter];
                                values[counter]=temp;
                                swap=true;
                        }
                }
                while(swap);
        }
        return 0;
}

---

it's giving me this error


" error C2059: syntax error : 'return "

please help

So has the formating of your coded helped any? - assuming Salem formated it for you.

gg

i still don't know the solution.....but i learned how to use the [code] thingies....i'm new at this....

I didn't know for loops ended with a while()....

still not working

What, do you expect us to be phsychic? Show the new code!

>> Show the new code!
Maybe there is no new code. He just wanted to remind us that it doesn't work.

Anyway, I'm going to bed. My last advice: Check the part on do-while() loops

Quote:

---

Originally Posted by Brad0407

>> Show the new code!
Maybe there is no new code. He just wanted to remind us that it doesn't work.

---

In which case ammanbesaw has not been reading anything we're written. And in which case ammanbesaw can figure out the problems without our help.

Your code is not indented correctly. Salem fixed it for you in your first post, so if you go back and read that, then you might find the answer to why it isn't working correctly.

He didn't make it work, he just made it so that you can see more easily where the problem is.

Look closer at your outer do-while loop... its quite easy to spot the mistake

Do you see anything wrong in statement

for (counter=0; counter<values[counter-1]; counter++)


?????

Quote:

---

Originally Posted by ammanbesaw

Code:

---


#include <iostream>

using namespace std;

int main()
{
        const int SIZE = 5;
        int values[SIZE], counter, temp;
        bool swap;

       
        for (counter=0; counter<SIZE; counter++)
        {
                cout<<"please input a number"<<endl;
                cin>>values[counter];
        }

        do
        {        swap = false;
                for (counter=0; counter<values[counter-1]; counter++)
                {
                        if (values[counter+1]>values[counter])
                        {
                                temp=values[counter];
                                values[counter+1]=values[counter];
                                values[counter]=temp;
                                swap=true;
                        }
                }
                while(swap);
        }
        return 0;
}

---

it's giving me this error


" error C2059: syntax error : 'return "

please help

---

There it is.

He's also going to get a crash because he's trying t o check an out-of-bounds array member. When counter = 0, he's trying to check

counter=0; counter<values[counter-1];

which is values[-1] !!!

Probably not a crash, but nevertheless not a good thing.

Change

Code:

---

                }
                while(swap);
        }

---

to

Code:

---

                }
       
        } while(swap);

---

The while statement should be after the closing bracket from do.



And I did get a crash in the middle of execution most likely because of what you guys just said (about out o' bounds array member)

Suggest you use std::vector instead of raw arrays. It will keep track of the bounds for you and throw an exception if you try to access a non-existent element.