data from terminal to a local file.

Guys,

what I am trying to accomplish is to catch output from keyboard and direct it to a file:

Code:

---

int main(){

  char buffer[128];
  int out, len;

  out = open("file.out", O_CREAT, S_IWUSR|S_IRUSR);
  len = read(0, &buffer, 128);
  do {
        write(out, &buffer, len);
  } while((len = read(0, &buffer, 128)) >= 128 );

  exit(0);
}

---

I am able to compile this perfectly fine. When I execute the binary it asks for input from terminal. file.out is created on local disk but... it is always empty.
please advice!!

Are you sure the first read() isn't returning 0?

gg

Quote:

---

Originally Posted by Codeplug

Are you sure the first read() isn't returning 0?

gg

---

I made the following modifications to the above code.

Code:

---

  out = open("file.out", O_CREAT, S_IWUSR|S_IRUSR);
  len = read(0, &buffer, 128);

  write(1, " value for len is "  , 64);
  write(1, &len, 2);

  do {
        write(out, &buffer, len);
  } while((len = read(0, &buffer, 128)) >= 128 );

---

after compiling the new code I get the following output which is definatly ODD... please advice...

Code:

---

Hi how are you>?
 value for len is $@þÿÿ@øþÿÿxXÿÿÿ

---

write() always writes in binary, so if you want to see the text representation of 'len', you have to convert it to a string yourself.

write() will also write the number of bytes that you tell it. That static string is not 64 bytes long. You can hard code 18 or make a "write_string" function that calls strlen().

gg

You are opening the output with mode O_CREAT. This does not allow writing to the file. Your calls to write() are doing nothing. You want to use O_CREAT | O_WRONLY.

Also, you are processing data in blocks of 128 bytes. One bug I see is that if the last block does not contain exactly 128 bytes, it won't get copied. Why are you checking if len >= 128? You ought to check just that it's greater than zero, meaning you got SOMETHING.

As it stands now, it will only do the right thing if the input is either less than 128 bytes, or, if greater than 128 bytes, is an exactly multiple of 128 bytes.

So you have two things to fix.