Problem with passing even ints into new array

Im working writing a program that outputs to a dos console. The even output comes out as a big negative number.

The code is here:

Code:

---


int * even (int *list, int size, int & esize)
//Pre: size > 0
//Post: return base address of new dynamic array containing even values
// from list array and set esize to the size of the new array
{

// Solving for the number of the Even Numbers
for (int i=0; i<size; i++)
{
if (list[i] % 2 == 0)
esize++;
}
int *leven = new int[esize];

//adding the even numbers into the array to be returned

for (int j = 0; j < size; j++)
{
if (list[j] % 2 ==0 )
{
for(int k = 0; k < esize; k++)
list[j] = leven [k];
}
}
return leven;

}

---

Thanks for any help

You're never actually assigning anything to the elements of leven. And this loop does nothing but assign leven[esize-1] (which is uninitialized) to each even element of list:

Code:

---

for(int k = 0; k < esize; k++)
list[j] = leven [k];

---

Also, this function seems to assume that esize is zero, which might cause problems if you inadvertently pass it a reference to a variable that is not initialized or initialized to a different value.

Also, using dynamic arrays is usually best to be avoided in C++. A safer choice is std::vector.

Indent properly please!
NOTE TO SELF: Need to learn how to use std::copy >_<

> memcpy(list, list1, *size1);
A useful short-cut for POD data like an array of int's, but if this were a more general thing capable of dealing with any data, then the programmed loops would be better.

It would be essential if it were a class where the assignment operator had been specified.

Besides, you forgot to scale the amount to copy by sizeof(int)

Yes, always the subtle bugs. Don't have time to test either, right now...

This is VERY wrong!

Quote:

---

Code:

---

                                leven += list[j];

---

---

That actually modifies the pointer value!
To write to the array you should use leven[foo] = bar; where foo is the index and bar is the value.
Then once you've written to leven[foo] you'll need to add one to foo so that the next item doesn't overwrite it. But if it is not even you don't add one because you wont be writing to array in that case.

Secondly, if you're going to list pre and post conditions then don't forget the obvious ones like say "list != NULL".

Thirdly, whilst there are some delete[] statements in your program, you're not doing a very consistent job of properly releasing the memory you obtain in every case, and hence still have leaks. You would be much better off simply using std::vector, since this is C++

Elysia, In the C++ world we use std::copy, not memcpy.

Quote:

---

Originally Posted by iMalc

Elysia, In the C++ world we use std::copy, not memcpy.

---

Didn't realize it was C++. Too much C >_<
Otherwise I'd suggested using vector a long time ago. Am I half-asleep or something?

got it. Danced around the answer for a while.