programmin woes

hi guys.

i've been making a simple (or so i thought) memory test game on c++ to help me learn. ive encountered a number of problems that were eventualy solvable and ive been at this one for hours:

Code:

---

#include <cstdlib>
#include <iostream>
#include <windows.h>
#include <stdlib.h>


using namespace std;

int main()

{
int numberarray[20];
int numberarrayplace;
int numberrecal;
int numberrecalamount;
int exitcheckloop;
cout<<"Welcome to Dave's memory lab! \n";
cout<<"Here we will carry out a test: \n";
cout<<"Remember the numbers! \n";;
cout<<"you have 30 seconds to memorize them \n";
cout<<"Then you will be tested \n";
cout<<"Press enter to continue... \n";
cin.get();
Sleep(1000);
cout<<"3 \n";
Sleep(1000);
cout<<"2 \n";
Sleep(1000);
cout<<"1 \n";
Sleep(1000);
system("cls");

cout<<"Here are your numbers \n";
numberarrayplace = 1;
do {
  numberarray[numberarrayplace] = rand() % 99 + 1;
  cout<< numberarray[numberarrayplace] << " \n";
  numberarrayplace = numberarrayplace + 1;
  } while ( numberarrayplace < 21 );
Sleep(30000);
system("cls");
cout<<"Times up! \n";
cout<<"Now you must type the numbers back in!  \n";

       
    numberarrayplace = 0;
    numberrecalamount = 1;
   
    do {
   
    cin>> numberrecal;
    exitcheckloop = 0;
    do {
           

    if ( numberarrayplace > 20 ) {
             
    cout<<"Incorrect! \n";
    numberrecalamount = numberrecalamount + 1;
    numberarrayplace = 0;
    exitcheckloop = 1;
    }
   
    else if ( numberarray[numberarrayplace] = numberrecal) {
    cout<<"Correct! \n";
    numberarrayplace = 0;
    numberrecalamount = numberrecalamount + 1;
    exitcheckloop = 1;
    }
   
    else {
    numberarrayplace = numberarrayplace + 1;
   
        }
        } while ( exitcheckloop = 0 );
   
    } while ( numberrecalamount < 21 );

}

---

in the phase of the user typing back the numbers no matter what you write it comes up as correct. im probably just being stupid but i cant work out how to make it come up as incorrect when the user puts an incorrect value.

can anyone help me !?!?!

thanks

gillypie

Well some half-decent indentation and vertical white-space (aka a blank line) would help you figure out the program flow (and help us in the process).

Code:

---

#include <cstdlib>
#include <iostream>
#include <windows.h>
// #include <stdlib.h> you already included cstdlib


using namespace std;

int main()
{
    int numberarray[20];
    int numberarrayplace;
    int numberrecal;
    int numberrecalamount;
    int exitcheckloop;
    cout << "Welcome to Dave's memory lab! \n";
    cout << "Here we will carry out a test: \n";
    cout << "Remember the numbers! \n";;
    cout << "you have 30 seconds to memorize them \n";
    cout << "Then you will be tested \n";
    cout << "Press enter to continue... \n";
    cin.get();
    Sleep(1000);
    cout << "3 \n";
    Sleep(1000);
    cout << "2 \n";
    Sleep(1000);
    cout << "1 \n";
    Sleep(1000);
    system("cls");

    cout << "Here are your numbers \n";
    numberarrayplace = 1;
    do {
        numberarray[numberarrayplace] = rand() % 99 + 1;
        cout << numberarray[numberarrayplace] << " \n";
        numberarrayplace = numberarrayplace + 1;
    } while (numberarrayplace < 21);

    Sleep(30000);
    system("cls");
    cout << "Times up! \n";
    cout << "Now you must type the numbers back in!  \n";

    numberarrayplace = 0;
    numberrecalamount = 1;

    do {
        cin >> numberrecal;
        exitcheckloop = 0;
        do {
            if (numberarrayplace > 20) {
                cout << "Incorrect! \n";
                numberrecalamount = numberrecalamount + 1;
                numberarrayplace = 0;
                exitcheckloop = 1;
            }
            else if (numberarray[numberarrayplace] = numberrecal) {
                cout << "Correct! \n";
                numberarrayplace = 0;
                numberrecalamount = numberrecalamount + 1;
                exitcheckloop = 1;
            }
            else {
                numberarrayplace = numberarrayplace + 1;

            }
        } while (exitcheckloop = 0);
    } while (numberrecalamount < 21);
}

---

Step 1 would be to replace an = with an ==

so when do i change the = to == ?

> else if (numberarray[numberarrayplace] = numberrecal)
What's this look like to you - assignment or comparison?

yeh i thought so but it didnt fix the problem

horrah there was another bit to do as well and it works.

here u go.

Code:

---

#include <cstdlib>
#include <iostream>
#include <windows.h>



using namespace std;

int main()
{
    int numberarray[20];
    int numberarrayplace;
    int numberrecal;
    int numberrecalamount;
    int exitcheckloop;
    cout << "Welcome to Dave's memory lab! \n";
    cout << "Here we will carry out a test: \n";
    cout << "Remember the numbers! \n";;
    cout << "you have 30 seconds to memorize them \n";
    cout << "Then you will be tested \n";
    cout << "Press enter to continue... \n";
    cin.get();
    Sleep(1000);
    cout << "3 \n";
    Sleep(1000);
    cout << "2 \n";
    Sleep(1000);
    cout << "1 \n";
    Sleep(1000);
    system("cls");

    cout << "Here are your numbers \n";
    numberarrayplace = 1;
    do {
        numberarray[numberarrayplace] = rand() &#37; 99 + 1;
        cout << numberarray[numberarrayplace] << " \n";
        numberarrayplace = numberarrayplace + 1;
    } while (numberarrayplace < 21);

    Sleep(30000);
    system("cls");
    cout << "Times up! \n";
    cout << "Now you must type the numbers back in!  \n";

    numberarrayplace = 0;
    numberrecalamount = 1;

    do {
        cin >> numberrecal;
        exitcheckloop = 0;
        do {
            if (numberarrayplace > 20) {
                cout << "Incorrect! \n";
                numberrecalamount = numberrecalamount + 1;
                numberarrayplace = 0;
                exitcheckloop = 1;
            }
            else if (numberarray[numberarrayplace] == numberrecal) {
                cout << "Correct! \n";
                numberarrayplace = 0;
                numberrecalamount = numberrecalamount + 1;
                exitcheckloop = 1;
            }
            else {
                numberarrayplace = numberarrayplace + 1;

            }
        } while (exitcheckloop == 0);
    } while (numberrecalamount < 21);
}

---

You code is full of buffer overruns.
Arrays start at zero and go up to n-1, where n is the array size, NOT 1 to n

oh guys one more thing.

Code:

---

#include <cstdlib>
#include <iostream>
#include <windows.h>



using namespace std;

int main()
{
    int numberarray[20];
    int numberarrayplace;
    int numberrecal;
    int numberrecalamount;
    int exitcheckloop;
    int memorycount;
    int memoryscore;
    int blah;
    cout << "Welcome to Dave's memory lab! \n";
    cout << "Here we will carry out a test: \n";
    cout << "Remember the numbers! \n";;
    cout << "you have 30 seconds to memorize them \n";
    cout << "Then you will be tested \n";
    cout << "Press enter to continue... \n";
    cin.get();
    Sleep(1000);
    cout << "3 \n";
    Sleep(1000);
    cout << "2 \n";
    Sleep(1000);
    cout << "1 \n";
    Sleep(1000);
    system("cls");

    cout << "Here are your numbers \n";
    numberarrayplace = 1;
    do {
        numberarray[numberarrayplace] = rand() &#37; 99 + 1;
        cout << numberarray[numberarrayplace] << " \n";
        numberarrayplace = numberarrayplace + 1;
    } while (numberarrayplace < 21);

    Sleep(3000);
    system("cls");
    cout << "Times up! \n";
    cout << "Now you must type the numbers back in!  \n";

    numberarrayplace = 0;
    numberrecalamount = 1;

    do {
        cin >> numberrecal;
        exitcheckloop = 0;
        do {
            if (numberarrayplace > 20) {
                cout << "Incorrect! \n";
                numberrecalamount = numberrecalamount + 1;
                numberarrayplace = 0;
                exitcheckloop = 1;
            }
            else if (numberarray[numberarrayplace] == numberrecal) {
                memorycount = memorycount + 1;
                cout << "Correct! \n";
                numberarrayplace = 0;
                numberrecalamount = numberrecalamount + 1;             
                exitcheckloop = 1;
                }
            else {
                numberarrayplace = numberarrayplace + 1;

            }
        } while (exitcheckloop == 0);
    } while (numberrecalamount < 21);

cout << "Ok let's see how you did... \n";
Sleep(2000);
memoryscore = 100 * (memorycount / 20);
cout << "You guessed " << memorycount << " awnsers";
cout << "Your memory score is " << memoryscore;
cin >> blah;
}

---

for some reason it gives a far fetched result like 90818573 or something. do u know why?

Quote:

---

Originally Posted by gillypie

for some reason it gives a far fetched result like 90818573 or something. do u know why?

---

It might be a good idea to initialize memorycount and get rid of the array overflows as well.
Kurt

what are array overflows?

Quote:

---

Originally Posted by gillypie

what are array overflows?

---

e.g. to write to numberarray[20] when the array has only 20 slots.
Kurt

oh i see so i only need [19] because 0 counts

k i fixed that but the problem remains

It's nice that you copy/pasted my nicely formatted version, but how come all the lines you've added make it look like a mess once more?

Focus on every single detail, and getting it right.

Oh, and post your latest code since you seem to have made some changes.

Code:

---

#include <cstdlib>
#include <iostream>
#include <windows.h>



using namespace std;

int main()
{
    int numberarray[19];
    int numberarrayplace;
    int numberrecal;
    int numberrecalamount;
    int exitcheckloop;
    int memorycount;
    int memoryscore;
    int blah;
    cout << "Welcome to Dave's memory lab! \n";
    cout << "Here we will carry out a test: \n";
    cout << "Remember the numbers! \n";;
    cout << "you have 30 seconds to memorize them \n";
    cout << "Then you will be tested \n";
    cout << "Press enter to continue... \n";
    cin.get();
    Sleep(1000);
    cout << "3 \n";
    Sleep(1000);
    cout << "2 \n";
    Sleep(1000);
    cout << "1 \n";
    Sleep(1000);
    system("cls");

    cout << "Here are your numbers \n";
    numberarrayplace = 1;
    do {
        numberarray[numberarrayplace] = rand() &#37; 99 + 1;
        cout << numberarray[numberarrayplace] << " \n";
        numberarrayplace = numberarrayplace + 1;
    } while (numberarrayplace < 21);

    Sleep(3000);
    system("cls");
    cout << "Times up! \n";
    cout << "Now you must type the numbers back in!  \n";

    numberarrayplace = 0;
    numberrecalamount = 1;
    memorycount = 0;

    do {
        cin >> numberrecal;
        exitcheckloop = 0;
        do {
            if (numberarrayplace > 19) {
                cout << "Incorrect! \n";
                numberrecalamount = numberrecalamount + 1;
                numberarrayplace = 0;
                exitcheckloop = 1;
            }
            else if (numberarray[numberarrayplace] == numberrecal) {
                memorycount = memorycount + 1;
                cout << "Correct! \n";
                numberarrayplace = 0;
                numberrecalamount = numberrecalamount + 1;             
                exitcheckloop = 1;
                }
            else {
                numberarrayplace = numberarrayplace + 1;

            }
        } while (exitcheckloop == 0);
    } while (numberrecalamount < 20);

cout << "Ok let's see how you did... \n";
Sleep(2000);
memorycount = 20;
memoryscore = 100 * (memorycount / 20);
cout << "Your memory score is " << memoryscore;
cin >> blah;

}

---

Code:

---

memoryscore = 100 * (memorycount / 20);

---

try this way

Code:

---

memoryscore = (100 * memorycount )/ 20;

---

Kurt

OK, so I take it you want a 20 element array?

Code:

---

    int numberarray[19];

---

This one holds 19 elements.

You then fill the array indexes 1..20:

Code:

---

    numberarrayplace = 1;
    do {
        numberarray[numberarrayplace] = rand() % 99 + 1;
        cout << numberarray[numberarrayplace] << " \n";
        numberarrayplace = numberarrayplace + 1;
    } while (numberarrayplace < 21);

---

When you only have 0..18...

That loop, by the way, should really be done as a for-loop. Using do - while is completely meaningless. And if you insist on using this loop-form, at least write numberarrayplace++ to add one to your current position.

Code:

---

    numberrecalamount = 1;
    memorycount = 0;

    do {
        cin >> numberrecal;
        exitcheckloop = 0;
        do {
            if (numberarrayplace > 19) {
                cout << "Incorrect! \n";
                numberrecalamount = numberrecalamount + 1;
                numberarrayplace = 0;
                exitcheckloop = 1;
            }
            else if (numberarray[numberarrayplace] == numberrecal) {
                memorycount = memorycount + 1;
                cout << "Correct! \n";
                numberarrayplace = 0;
                numberrecalamount = numberrecalamount + 1;             
                exitcheckloop = 1;
                }
            else {
                numberarrayplace = numberarrayplace + 1;

            }
        } while (exitcheckloop == 0);
    } while (numberrecalamount < 20);

---

Now you check the elements from 1..19.

And again, it would be much clearer with a for-loop (using break to exit the loop), and at least using "variable++" where you increment something.

Code:

---

memorycount = 20;
memoryscore = 100 * (memorycount / 20);

---

You are not going to get much other than 100 out of this, are you?

But more importantly, if memorycount is not 20, then you'll always get zero, becuase x / y in integer math becomes zero if abs(x) < abs(y). Perhaps you would prefer to multiply memorycount by 100 first, then divide by the number of questions. That way, you get a "percentage number".

Edit: Kurt beat me to the last one.

--
Mats

Horray it works.

Thanks for all your help guys !!!