issue with determining EOF

I have a file with a random number of integers, all on their own line, and the program needs to read them in. All is good, except being able to tell the computer where the end of the file is at. For a test file I put 21 numbers (positive and negative) in random order, and the program says there is 25 numbers, with a very small value for the highest and lowest number (ie -124325).

Code:

---

myfile>>inarray[n];
high = inarray[n];
low = inarray[n];

while(inarray[n] != EOF){    //also tried while(inarray[n] != NULL)

    n++;
    myfile>>inarray[n];
    if(high < inarray[n])
        high = inarray[n];
    if(low > inarray[n])
        low = inarray[n];

}

cout<<"low: "<< low <<endl;
cout<<"high: "<< high <<endl;
cout<<"max: "<< n <<endl;

---

what is inarray?

The array i'm storying all the integers in to. The array is the input, hence calling it "inarray".

The extraction operator never yields EOF. Use the boolean conversion of the stream object itself:

Code:

---

while(myfile) {

---

Better yet, do it like this:

Code:

---

myfile>>inarray[n];
high = inarray[n];
low = inarray[n];
++n;

while(myfile >> inarray[n]){    //also tried while(inarray[n] != NULL)
    if(high < inarray[n])
        high = inarray[n];
    if(low > inarray[n])
        low = inarray[n];
    ++n;
}

---

Of course, you'll have to adjust your code to account for the fact that n is one higher than in your version.

What does this have to do with Linux, anyway? Moved.

The programming is done on a linux based server, didnt really know if it should be in c++ or linux. Thanks for the idea, I will try it out.

As a rule, it goes into Linux if it has Linux-specific concepts. When in doubt, don't put it in Linux.