Printing to file / Output issues

I'm trying to make a program that outputs every hour and minute of the day in

hh:mm format and then print all of that to a text file.

However, I have no idea how to make it go about printing it as

00:00
00:01
00:02 and so on.

Any help would be appreciated, as well as how to make it write every single timestamp to a text file.

Thanks in advance.

Code:

---

#include <iostream>
#include <fstream>
#include <iomanip>

using namespace std;

int main ()
{
  int n;
  int m;
  cin >> n;
      while (n>-2 && n<24)
      {
      cout << setfill('0') << setw(2) << ++n << "";
      }
  cin >> m;
      while (m>-2 && m<60)
      {
  cout << setfill('0') << setw(2) << ++m << "";
      }
  cout << n << ":" << m;
  system("PAUSE");
  EXIT_SUCCESS;
}

---

A for loop which counts the hours, and within that, a for loop which counts the minutes.

I am new to c++ and a noob at it, could you help me out a little more than that, pretty please? :D

Why?
Since you spent less than a minute to reply rather than going away to look at some reference material to see if you could manage it yourself.

You've already managed the hard part (IMO) of making cout output leading zeros.

Because I messed around with it a lot before coming to ask for help. I wouldn't come and ask for help if I had a clue.

On a side note dont use system("pause"); system calls are unsafe.

Use std::cin,get(); to freeze the console output. If your using std::cin >> as you are in this program depending on your compiler you may have to add std::cin.ignore() underneath you ignore the whitespace.

Ah, thank you kindly for the tip. I will use that from now on. =)

So :(
for ( m = 0 ; m < 10 ; m++ )

This is a real simple program, the basic outline is:

• Open output file
• for loop through the hours (0-23 inclusive)
  
  • for loop through the minutes (0-59 inclusive)
    
    • print hour/minutes in HH:MM format using cout
    • print same thing a above, but to file this time

So, read up on for loops and nested loops along with some file I/O using fstream objects and you're done.

Code:

---

#include <iostream>
#include <fstream>
#include <iomanip>

using namespace std;

int main ()
{
    int hh;
    int mm;
    for ( mm = 0 ; mm < 59 ; mm++)
    for ( hh = 0 ; hh < 24 ; hh++)
   
    ofstream myfile;
    myfile.open ("TimeStamps.txt");
    cout.fill('0');
    myfile.fill('0');
    myfile << setw(2) << mm << ":" << hh;
    cout.fill(' ');
    myfile.fill(' ');
    myfile.close;

---

Changed it up a little, but it gives me the error of:

"14 C:\Dev-Cpp\Practice\Time1.cpp `myfile' undeclared (first use this function)"

Code:

---

>    ofstream myfile;
>    myfile.open ("TimeStamps.txt");

---

You need to move these lines outside the for-loop. Otherwise the scope of myfile is only within the loop. Also:

Code:

---

>    myfile.close;

---

Should be:

Code:

---

    myfile.close();

---

Like this?

Code:

---

#include <iostream>
#include <fstream>
#include <iomanip>

using namespace std;

int main ()
{
    int hh;
    int mm;
       
    ofstream myfile;
    myfile.open ("TimeStamps.txt");
    for ( mm = 0 ; mm < 59 ; mm++)
    for ( hh = 0 ; hh < 24 ; hh++)

    cout.fill('0');
    myfile.fill('0');
    myfile << setw(2) << hh << ":" << mm;
    cout.fill(' ');
    myfile.fill(' ');
    myfile.close();

---

It's only outputting this: "24:59"
Not sure what is wrong with it now. :(

>It's only outputting this: "24:59"
This is true. A for-loop only executes a single statement, unless you include braces to indicate otherwise. This is one reason it's important to properly indent one's code.

Your loops need braces around the code that is supposed to be in the loop. Otherwise, only the next statement will be a part of that loop. In this case, that means that your loops only execute the cout.fill('0'); line over and over again 1500 times, then execute the code after it once.

BTW, your first loop should probably stop at 60, not 59.

I have no idea how to go about fixing that. Could you point me into the right direction or something? And I didn't think the indents were a big deal on small code, usually pretty easy to follow, no?

Quote:

---

Originally Posted by Daved

Your loops need braces around the code that is supposed to be in the loop. Otherwise, only the next statement will be a part of that loop. In this case, that means that your loops only execute the cout.fill('0'); line over and over again 1500 times, then execute the code after it once.

BTW, your first loop should probably stop at 60, not 59.

---

It's supposed to be a clock, for some reason if you do it up to 60, it includes 60. at 60 mm it technically goes up an hour.

It only includes 60 because of your other problem of not adding the braces. Notice how it outputs 24:59, but there isn't supposed to be a 24 hour either.

To fix your problem, just add braces around the code that belongs in the loop. The first step is to identify which code belongs in the loop. Can you identify the lines of code you think need to be repeated each time and therefore belong in the loop?

The syntax of a for loop is:

Code:

---

for (blah; blah; blah)
{
    // code goes here
    // and repeats
    // each time in the loop.
}

---

You are missing the blue things.

Personally I think this when you tell me that:

Code:

---

#include <iostream>
#include <fstream>
#include <iomanip>

using namespace std;

int main ()
{
    int hh;
    int mm;
       
    ofstream myfile;
    myfile.open ("TimeStamps.txt");
    for ( mm = 0 ; mm < 59 ; mm++)
    for ( hh = 0 ; hh < 24 ; hh++)

        {cout.fill('0');
    myfile.fill('0');
    myfile << setw(2) << hh << ":" << mm;
        }
    cout.fill(' ');
    myfile.fill(' ');
    myfile.close();

---

But I think that only does one of the for loops, aye?

edit: that fills my text file with a huge amount of ''''''''''''''s

That looks good to me for the inner loop.

You would normally add the braces for each for loop separately. You want the outer for loop to contain the entire inner for loop, so you would add the starting brace before the second for statement (the start of the inner loop) and the closing brace after the closing brace of the inner loop (which is the end of the inner loop). In this case it actually isn't needed, since that whole block is counted as one block and is all repeated anyway, but for clarity and good practice you should add those braces.

As for the output in the file, that is really weird. It happens for me when I use notepad to open it, but not when I open it with another editor. Try adding a newline or space after the minute is output, then you should be able to see it better.

I'm going to follow what seems to be forum etiquette and not flat out do it for you, but I will fix your tab problem, then you should be able to see the problem easier:

Code:

---

#include <iostream>
#include <fstream>
#include <iomanip>

using namespace std;

int main ()
{
        int hh;
        int mm;
       
        ofstream myfile;
        myfile.open ("TimeStamps.txt");

        for ( mm = 0 ; mm < 59 ; mm++)
                for ( hh = 0 ; hh < 24 ; hh++)
                {
                        cout.fill('0');
                        myfile.fill('0');
                        myfile << setw(2) << hh << ":" << mm;
                }

                cout.fill(' ');
                myfile.fill(' ');
                myfile.close();
        ...

---